Commit a8ef7bab by Carsten Brandt

Merge branch 'code-style'

* code-style: fix php5.4 array syntax many phpcs fixes fix phpDoc LuaScriptBuilder build @throws returned back formatting language files code style. WHILE code style. FOR code style. FOREACH code style. operator IF @param, @var, @property and @return must declare types as boolean, integer, string, array or null short echo tags short array syntax
parents fe48ae0d 1b7e1cd0
...@@ -141,7 +141,7 @@ class User extends ActiveRecord implements IdentityInterface ...@@ -141,7 +141,7 @@ class User extends ActiveRecord implements IdentityInterface
* Validates password * Validates password
* *
* @param string $password password to validate * @param string $password password to validate
* @return bool if password provided is valid for current user * @return boolean if password provided is valid for current user
*/ */
public function validatePassword($password) public function validatePassword($password)
{ {
......
...@@ -92,7 +92,7 @@ class User extends \yii\base\Object implements \yii\web\IdentityInterface ...@@ -92,7 +92,7 @@ class User extends \yii\base\Object implements \yii\web\IdentityInterface
* Validates password * Validates password
* *
* @param string $password password to validate * @param string $password password to validate
* @return bool if password provided is valid for current user * @return boolean if password provided is valid for current user
*/ */
public function validatePassword($password) public function validatePassword($password)
{ {
......
...@@ -24,7 +24,7 @@ class PhpDocController extends Controller ...@@ -24,7 +24,7 @@ class PhpDocController extends Controller
public $defaultAction = 'property'; public $defaultAction = 'property';
/** /**
* @var bool whether to update class docs directly. Setting this to false will just output docs * @var boolean whether to update class docs directly. Setting this to false will just output docs
* for copy and paste. * for copy and paste.
*/ */
public $updateFiles = true; public $updateFiles = true;
...@@ -314,7 +314,7 @@ class PhpDocController extends Controller ...@@ -314,7 +314,7 @@ class PhpDocController extends Controller
// check if parent class has setter defined // check if parent class has setter defined
$c = $className; $c = $className;
$parentSetter = false; $parentSetter = false;
while($parent = get_parent_class($c)) { while ($parent = get_parent_class($c)) {
if (method_exists($parent, 'set' . ucfirst($propName))) { if (method_exists($parent, 'set' . ucfirst($propName))) {
$parentSetter = true; $parentSetter = true;
break; break;
...@@ -329,7 +329,7 @@ class PhpDocController extends Controller ...@@ -329,7 +329,7 @@ class PhpDocController extends Controller
// check if parent class has getter defined // check if parent class has getter defined
$c = $className; $c = $className;
$parentGetter = false; $parentGetter = false;
while($parent = get_parent_class($c)) { while ($parent = get_parent_class($c)) {
if (method_exists($parent, 'set' . ucfirst($propName))) { if (method_exists($parent, 'set' . ucfirst($propName))) {
$parentGetter = true; $parentGetter = true;
break; break;
......
...@@ -120,7 +120,7 @@ needs to be divisible by 10. In the rules you would define: `['attributeName', ' ...@@ -120,7 +120,7 @@ needs to be divisible by 10. In the rules you would define: `['attributeName', '
Then, your own method could look like this: Then, your own method could look like this:
```php ```php
public function myValidationMethod($attribute) { public function myValidationMethod($attribute) {
if(($this->$attribute % 10) != 0) { if (($this->$attribute % 10) != 0) {
$this->addError($attribute, 'cannot divide value by 10'); $this->addError($attribute, 'cannot divide value by 10');
} }
} }
......
...@@ -252,7 +252,7 @@ if ($event === null) { ...@@ -252,7 +252,7 @@ if ($event === null) {
} }
// the following is NOT allowed: // the following is NOT allowed:
if(!$model && null === $event) if (!$model && null === $event)
throw new Exception('test'); throw new Exception('test');
``` ```
......
...@@ -25,7 +25,7 @@ use yii\widgets\ActiveForm; ...@@ -25,7 +25,7 @@ use yii\widgets\ActiveForm;
$this->title = 'Posts'; $this->title = 'Posts';
?> ?>
<!-- Separate PHP blocks are preferred for foreach, for, if etc. --> <!-- Separate PHP blocks are preferred for foreach, for, if etc. -->
<?php foreach($posts as $post): ?> <?php foreach ($posts as $post): ?>
<!-- Note indentation level here. --> <!-- Note indentation level here. -->
<h2><?= Html::encode($post['title']) ?></h2> <h2><?= Html::encode($post['title']) ?></h2>
<p><?= Html::encode($post['shortDescription']) ?></p> <p><?= Html::encode($post['shortDescription']) ?></p>
......
...@@ -15,7 +15,7 @@ $composerAutoload = [ ...@@ -15,7 +15,7 @@ $composerAutoload = [
__DIR__ . '/../../autoload.php', // script is installed as a composer binary __DIR__ . '/../../autoload.php', // script is installed as a composer binary
]; ];
$vendorPath = null; $vendorPath = null;
foreach($composerAutoload as $autoload) { foreach ($composerAutoload as $autoload) {
if (file_exists($autoload)) { if (file_exists($autoload)) {
require($autoload); require($autoload);
$vendorPath = dirname($autoload); $vendorPath = dirname($autoload);
...@@ -27,7 +27,7 @@ $yiiDirs = [ ...@@ -27,7 +27,7 @@ $yiiDirs = [
__DIR__ . '/vendor/yiisoft/yii2', // standalone with "composer install" run __DIR__ . '/vendor/yiisoft/yii2', // standalone with "composer install" run
__DIR__ . '/../../yiisoft/yii2', // script is installed as a composer binary __DIR__ . '/../../yiisoft/yii2', // script is installed as a composer binary
]; ];
foreach($yiiDirs as $dir) { foreach ($yiiDirs as $dir) {
if (file_exists($dir . '/Yii.php')) { if (file_exists($dir . '/Yii.php')) {
require($dir . '/Yii.php'); require($dir . '/Yii.php');
break; break;
......
...@@ -70,7 +70,7 @@ class ApiMarkdown extends GithubMarkdown ...@@ -70,7 +70,7 @@ class ApiMarkdown extends GithubMarkdown
if (!empty($language)) { if (!empty($language)) {
$block['language'] = $language; $block['language'] = $language;
} }
for($i = $current + 1, $count = count($lines); $i < $count; $i++) { for ($i = $current + 1, $count = count($lines); $i < $count; $i++) {
if (rtrim($line = $lines[$i]) !== $fence) { if (rtrim($line = $lines[$i]) !== $fence) {
$block['content'][] = $line; $block['content'][] = $line;
} else { } else {
...@@ -224,7 +224,7 @@ class ApiMarkdown extends GithubMarkdown ...@@ -224,7 +224,7 @@ class ApiMarkdown extends GithubMarkdown
* *
* @param string $content * @param string $content
* @param TypeDoc $context * @param TypeDoc $context
* @param bool $paragraph * @param boolean $paragraph
* @return string * @return string
*/ */
public static function process($content, $context = null, $paragraph = false) public static function process($content, $context = null, $paragraph = false)
......
...@@ -76,7 +76,7 @@ class BaseDoc extends Object ...@@ -76,7 +76,7 @@ class BaseDoc extends Object
$this->phpDocContext = $docblock->getContext(); $this->phpDocContext = $docblock->getContext();
$this->tags = $docblock->getTags(); $this->tags = $docblock->getTags();
foreach($this->tags as $i => $tag) { foreach ($this->tags as $i => $tag) {
if ($tag instanceof SinceTag) { if ($tag instanceof SinceTag) {
$this->since = $tag->getVersion(); $this->since = $tag->getVersion();
unset($this->tags[$i]); unset($this->tags[$i]);
......
...@@ -45,12 +45,12 @@ class ClassDoc extends TypeDoc ...@@ -45,12 +45,12 @@ class ClassDoc extends TypeDoc
if (($subject = parent::findSubject($subjectName)) !== null) { if (($subject = parent::findSubject($subjectName)) !== null) {
return $subject; return $subject;
} }
foreach($this->events as $name => $event) { foreach ($this->events as $name => $event) {
if ($subjectName == $name) { if ($subjectName == $name) {
return $event; return $event;
} }
} }
foreach($this->constants as $name => $constant) { foreach ($this->constants as $name => $constant) {
if ($subjectName == $name) { if ($subjectName == $name) {
return $constant; return $constant;
} }
...@@ -64,7 +64,7 @@ class ClassDoc extends TypeDoc ...@@ -64,7 +64,7 @@ class ClassDoc extends TypeDoc
public function getNativeEvents() public function getNativeEvents()
{ {
$events = []; $events = [];
foreach($this->events as $name => $event) { foreach ($this->events as $name => $event) {
if ($event->definedBy != $this->name) { if ($event->definedBy != $this->name) {
continue; continue;
} }
...@@ -93,13 +93,13 @@ class ClassDoc extends TypeDoc ...@@ -93,13 +93,13 @@ class ClassDoc extends TypeDoc
$this->isAbstract = $reflector->isAbstract(); $this->isAbstract = $reflector->isAbstract();
$this->isFinal = $reflector->isFinal(); $this->isFinal = $reflector->isFinal();
foreach($reflector->getInterfaces() as $interface) { foreach ($reflector->getInterfaces() as $interface) {
$this->interfaces[] = ltrim($interface, '\\'); $this->interfaces[] = ltrim($interface, '\\');
} }
foreach($reflector->getTraits() as $trait) { foreach ($reflector->getTraits() as $trait) {
$this->traits[] = ltrim($trait, '\\'); $this->traits[] = ltrim($trait, '\\');
} }
foreach($reflector->getConstants() as $constantReflector) { foreach ($reflector->getConstants() as $constantReflector) {
$docblock = $constantReflector->getDocBlock(); $docblock = $constantReflector->getDocBlock();
if ($docblock !== null && count($docblock->getTagsByName('event')) > 0) { if ($docblock !== null && count($docblock->getTagsByName('event')) > 0) {
$event = new EventDoc($constantReflector); $event = new EventDoc($constantReflector);
......
...@@ -57,15 +57,15 @@ class Context extends Component ...@@ -57,15 +57,15 @@ class Context extends Component
$reflection = new FileReflector($fileName, true); $reflection = new FileReflector($fileName, true);
$reflection->process(); $reflection->process();
foreach($reflection->getClasses() as $class) { foreach ($reflection->getClasses() as $class) {
$class = new ClassDoc($class, $this, ['sourceFile' => $fileName]); $class = new ClassDoc($class, $this, ['sourceFile' => $fileName]);
$this->classes[$class->name] = $class; $this->classes[$class->name] = $class;
} }
foreach($reflection->getInterfaces() as $interface) { foreach ($reflection->getInterfaces() as $interface) {
$interface = new InterfaceDoc($interface, $this, ['sourceFile' => $fileName]); $interface = new InterfaceDoc($interface, $this, ['sourceFile' => $fileName]);
$this->interfaces[$interface->name] = $interface; $this->interfaces[$interface->name] = $interface;
} }
foreach($reflection->getTraits() as $trait) { foreach ($reflection->getTraits() as $trait) {
$trait = new TraitDoc($trait, $this, ['sourceFile' => $fileName]); $trait = new TraitDoc($trait, $this, ['sourceFile' => $fileName]);
$this->traits[$trait->name] = $trait; $this->traits[$trait->name] = $trait;
} }
...@@ -74,7 +74,7 @@ class Context extends Component ...@@ -74,7 +74,7 @@ class Context extends Component
public function updateReferences() public function updateReferences()
{ {
// update all subclass references // update all subclass references
foreach($this->classes as $class) { foreach ($this->classes as $class) {
$className = $class->name; $className = $class->name;
while (isset($this->classes[$class->parentClass])) { while (isset($this->classes[$class->parentClass])) {
$class = $this->classes[$class->parentClass]; $class = $this->classes[$class->parentClass];
...@@ -82,12 +82,12 @@ class Context extends Component ...@@ -82,12 +82,12 @@ class Context extends Component
} }
} }
// update interfaces of subclasses // update interfaces of subclasses
foreach($this->classes as $class) { foreach ($this->classes as $class) {
$this->updateSubclassInferfacesTraits($class); $this->updateSubclassInferfacesTraits($class);
} }
// update implementedBy and usedBy for interfaces and traits // update implementedBy and usedBy for interfaces and traits
foreach($this->classes as $class) { foreach ($this->classes as $class) {
foreach($class->traits as $trait) { foreach ($class->traits as $trait) {
if (isset($this->traits[$trait])) { if (isset($this->traits[$trait])) {
$trait = $this->traits[$trait]; $trait = $this->traits[$trait];
$trait->usedBy[] = $class->name; $trait->usedBy[] = $class->name;
...@@ -95,12 +95,12 @@ class Context extends Component ...@@ -95,12 +95,12 @@ class Context extends Component
$class->methods = array_merge($trait->methods, $class->methods); $class->methods = array_merge($trait->methods, $class->methods);
} }
} }
foreach($class->interfaces as $interface) { foreach ($class->interfaces as $interface) {
if (isset($this->interfaces[$interface])) { if (isset($this->interfaces[$interface])) {
$this->interfaces[$interface]->implementedBy[] = $class->name; $this->interfaces[$interface]->implementedBy[] = $class->name;
if ($class->isAbstract) { if ($class->isAbstract) {
// add not implemented interface methods // add not implemented interface methods
foreach($this->interfaces[$interface]->methods as $method) { foreach ($this->interfaces[$interface]->methods as $method) {
if (!isset($class->methods[$method->name])) { if (!isset($class->methods[$method->name])) {
$class->methods[$method->name] = $method; $class->methods[$method->name] = $method;
} }
...@@ -110,15 +110,15 @@ class Context extends Component ...@@ -110,15 +110,15 @@ class Context extends Component
} }
} }
// inherit docs // inherit docs
foreach($this->classes as $class) { foreach ($this->classes as $class) {
$this->inheritDocs($class); $this->inheritDocs($class);
} }
// inherit properties, methods, contants and events to subclasses // inherit properties, methods, contants and events to subclasses
foreach($this->classes as $class) { foreach ($this->classes as $class) {
$this->updateSubclassInheritance($class); $this->updateSubclassInheritance($class);
} }
// add properties from getters and setters // add properties from getters and setters
foreach($this->classes as $class) { foreach ($this->classes as $class) {
$this->handlePropertyFeature($class); $this->handlePropertyFeature($class);
} }
...@@ -131,7 +131,7 @@ class Context extends Component ...@@ -131,7 +131,7 @@ class Context extends Component
*/ */
protected function updateSubclassInferfacesTraits($class) protected function updateSubclassInferfacesTraits($class)
{ {
foreach($class->subclasses as $subclass) { foreach ($class->subclasses as $subclass) {
$subclass = $this->classes[$subclass]; $subclass = $this->classes[$subclass];
$subclass->interfaces = array_unique(array_merge($subclass->interfaces, $class->interfaces)); $subclass->interfaces = array_unique(array_merge($subclass->interfaces, $class->interfaces));
$subclass->traits = array_unique(array_merge($subclass->traits, $class->traits)); $subclass->traits = array_unique(array_merge($subclass->traits, $class->traits));
...@@ -145,7 +145,7 @@ class Context extends Component ...@@ -145,7 +145,7 @@ class Context extends Component
*/ */
protected function updateSubclassInheritance($class) protected function updateSubclassInheritance($class)
{ {
foreach($class->subclasses as $subclass) { foreach ($class->subclasses as $subclass) {
$subclass = $this->classes[$subclass]; $subclass = $this->classes[$subclass];
$subclass->events = array_merge($class->events, $subclass->events); $subclass->events = array_merge($class->events, $subclass->events);
$subclass->constants = array_merge($class->constants, $subclass->constants); $subclass->constants = array_merge($class->constants, $subclass->constants);
...@@ -203,7 +203,7 @@ class Context extends Component ...@@ -203,7 +203,7 @@ class Context extends Component
if (!$this->isSubclassOf($class, 'yii\base\Object')) { if (!$this->isSubclassOf($class, 'yii\base\Object')) {
return; return;
} }
foreach($class->getPublicMethods() as $name => $method) { foreach ($class->getPublicMethods() as $name => $method) {
if ($method->isStatic) { if ($method->isStatic) {
continue; continue;
} }
...@@ -275,7 +275,7 @@ class Context extends Component ...@@ -275,7 +275,7 @@ class Context extends Component
*/ */
private function paramsOptional($method, $number = 0) private function paramsOptional($method, $number = 0)
{ {
foreach($method->params as $param) { foreach ($method->params as $param) {
if (!$param->isOptional && $number-- <= 0) { if (!$param->isOptional && $number-- <= 0) {
return false; return false;
} }
...@@ -289,7 +289,7 @@ class Context extends Component ...@@ -289,7 +289,7 @@ class Context extends Component
*/ */
private function getFirstNotOptionalParameter($method) private function getFirstNotOptionalParameter($method)
{ {
foreach($method->params as $param) { foreach ($method->params as $param) {
if (!$param->isOptional) { if (!$param->isOptional) {
return $param; return $param;
} }
...@@ -309,7 +309,7 @@ class Context extends Component ...@@ -309,7 +309,7 @@ class Context extends Component
if ($classA->name == $classB) { if ($classA->name == $classB) {
return true; return true;
} }
while($classA->parentClass !== null && isset($this->classes[$classA->parentClass])) { while ($classA->parentClass !== null && isset($this->classes[$classA->parentClass])) {
$classA = $this->classes[$classA->parentClass]; $classA = $this->classes[$classA->parentClass];
if ($classA->name == $classB) { if ($classA->name == $classB) {
return true; return true;
......
...@@ -34,7 +34,7 @@ class EventDoc extends ConstDoc ...@@ -34,7 +34,7 @@ class EventDoc extends ConstDoc
return; return;
} }
foreach($this->tags as $i => $tag) { foreach ($this->tags as $i => $tag) {
if ($tag->getName() == 'event') { if ($tag->getName() == 'event') {
$eventTag = new ReturnTag('event', $tag->getContent(), $tag->getDocBlock(), $tag->getLocation()); $eventTag = new ReturnTag('event', $tag->getContent(), $tag->getDocBlock(), $tag->getLocation());
$this->type = $eventTag->getType(); $this->type = $eventTag->getType();
......
...@@ -45,12 +45,12 @@ class FunctionDoc extends BaseDoc ...@@ -45,12 +45,12 @@ class FunctionDoc extends BaseDoc
$this->isReturnByReference = $reflector->isByRef(); $this->isReturnByReference = $reflector->isByRef();
foreach($reflector->getArguments() as $arg) { foreach ($reflector->getArguments() as $arg) {
$arg = new ParamDoc($arg, $context, ['sourceFile' => $this->sourceFile]); $arg = new ParamDoc($arg, $context, ['sourceFile' => $this->sourceFile]);
$this->params[$arg->name] = $arg; $this->params[$arg->name] = $arg;
} }
foreach($this->tags as $i => $tag) { foreach ($this->tags as $i => $tag) {
if ($tag instanceof ThrowsTag) { if ($tag instanceof ThrowsTag) {
$this->exceptions[$tag->getType()] = $tag->getDescription(); $this->exceptions[$tag->getType()] = $tag->getDescription();
unset($this->tags[$i]); unset($this->tags[$i]);
......
...@@ -33,11 +33,11 @@ class InterfaceDoc extends TypeDoc ...@@ -33,11 +33,11 @@ class InterfaceDoc extends TypeDoc
return; return;
} }
foreach($reflector->getParentInterfaces() as $interface) { foreach ($reflector->getParentInterfaces() as $interface) {
$this->parentInterfaces[] = ltrim($interface, '\\'); $this->parentInterfaces[] = ltrim($interface, '\\');
} }
foreach($this->methods as $method) { foreach ($this->methods as $method) {
$method->isAbstract = true; $method->isAbstract = true;
} }
......
...@@ -63,7 +63,7 @@ class PropertyDoc extends BaseDoc ...@@ -63,7 +63,7 @@ class PropertyDoc extends BaseDoc
$this->defaultValue = PrettyPrinter::getRepresentationOfValue($reflector->getNode()->default); $this->defaultValue = PrettyPrinter::getRepresentationOfValue($reflector->getNode()->default);
} }
foreach($this->tags as $tag) { foreach ($this->tags as $tag) {
if ($tag instanceof VarTag) { if ($tag instanceof VarTag) {
$this->type = $tag->getType(); $this->type = $tag->getType();
$this->types = $tag->getTypes(); $this->types = $tag->getTypes();
......
...@@ -34,7 +34,7 @@ class TraitDoc extends TypeDoc ...@@ -34,7 +34,7 @@ class TraitDoc extends TypeDoc
return; return;
} }
foreach($reflector->getTraits() as $trait) { foreach ($reflector->getTraits() as $trait) {
$this->traits[] = ltrim($trait, '\\'); $this->traits[] = ltrim($trait, '\\');
} }
} }
......
...@@ -41,7 +41,7 @@ class TypeDoc extends BaseDoc ...@@ -41,7 +41,7 @@ class TypeDoc extends BaseDoc
public function findSubject($subjectName) public function findSubject($subjectName)
{ {
if ($subjectName[0] != '$') { if ($subjectName[0] != '$') {
foreach($this->methods as $name => $method) { foreach ($this->methods as $name => $method) {
if (rtrim($subjectName, '()') == $name) { if (rtrim($subjectName, '()') == $name) {
return $method; return $method;
} }
...@@ -53,7 +53,7 @@ class TypeDoc extends BaseDoc ...@@ -53,7 +53,7 @@ class TypeDoc extends BaseDoc
if ($this->properties === null) { if ($this->properties === null) {
return null; return null;
} }
foreach($this->properties as $name => $property) { foreach ($this->properties as $name => $property) {
if (ltrim($subjectName, '$') == ltrim($name, '$')) { if (ltrim($subjectName, '$') == ltrim($name, '$')) {
return $property; return $property;
} }
...@@ -93,7 +93,7 @@ class TypeDoc extends BaseDoc ...@@ -93,7 +93,7 @@ class TypeDoc extends BaseDoc
private function getFilteredMethods($visibility = null, $definedBy = null) private function getFilteredMethods($visibility = null, $definedBy = null)
{ {
$methods = []; $methods = [];
foreach($this->methods as $name => $method) { foreach ($this->methods as $name => $method) {
if ($visibility !== null && $method->visibility != $visibility) { if ($visibility !== null && $method->visibility != $visibility) {
continue; continue;
} }
...@@ -140,7 +140,7 @@ class TypeDoc extends BaseDoc ...@@ -140,7 +140,7 @@ class TypeDoc extends BaseDoc
return []; return [];
} }
$properties = []; $properties = [];
foreach($this->properties as $name => $property) { foreach ($this->properties as $name => $property) {
if ($visibility !== null && $property->visibility != $visibility) { if ($visibility !== null && $property->visibility != $visibility) {
continue; continue;
} }
...@@ -167,14 +167,14 @@ class TypeDoc extends BaseDoc ...@@ -167,14 +167,14 @@ class TypeDoc extends BaseDoc
return; return;
} }
foreach($this->tags as $i => $tag) { foreach ($this->tags as $i => $tag) {
if ($tag instanceof AuthorTag) { if ($tag instanceof AuthorTag) {
$this->authors[$tag->getAuthorName()] = $tag->getAuthorEmail(); $this->authors[$tag->getAuthorName()] = $tag->getAuthorEmail();
unset($this->tags[$i]); unset($this->tags[$i]);
} }
} }
foreach($reflector->getProperties() as $propertyReflector) { foreach ($reflector->getProperties() as $propertyReflector) {
if ($propertyReflector->getVisibility() != 'private') { if ($propertyReflector->getVisibility() != 'private') {
$property = new PropertyDoc($propertyReflector, $context, ['sourceFile' => $this->sourceFile]); $property = new PropertyDoc($propertyReflector, $context, ['sourceFile' => $this->sourceFile]);
$property->definedBy = $this->name; $property->definedBy = $this->name;
...@@ -182,7 +182,7 @@ class TypeDoc extends BaseDoc ...@@ -182,7 +182,7 @@ class TypeDoc extends BaseDoc
} }
} }
foreach($reflector->getMethods() as $methodReflector) { foreach ($reflector->getMethods() as $methodReflector) {
if ($methodReflector->getVisibility() != 'private') { if ($methodReflector->getVisibility() != 'private') {
$method = new MethodDoc($methodReflector, $context, ['sourceFile' => $this->sourceFile]); $method = new MethodDoc($methodReflector, $context, ['sourceFile' => $this->sourceFile]);
$method->definedBy = $this->name; $method->definedBy = $this->name;
......
...@@ -153,7 +153,7 @@ class SideNavWidget extends \yii\bootstrap\Widget ...@@ -153,7 +153,7 @@ class SideNavWidget extends \yii\bootstrap\Widget
$label .= ' ' . Html::tag('b', '', ['class' => 'caret']); $label .= ' ' . Html::tag('b', '', ['class' => 'caret']);
if (is_array($items)) { if (is_array($items)) {
if ($active === false) { if ($active === false) {
foreach($items as $subItem) { foreach ($items as $subItem) {
if (isset($subItem['active']) && $subItem['active']) { if (isset($subItem['active']) && $subItem['active']) {
$active = true; $active = true;
} }
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\apidoc\templates\bootstrap\assets; namespace yii\apidoc\templates\bootstrap\assets;
use yii\web\View; use yii\web\View;
/** /**
......
...@@ -20,7 +20,7 @@ $this->beginContent('@yii/apidoc/templates/bootstrap/layouts/main.php'); ?> ...@@ -20,7 +20,7 @@ $this->beginContent('@yii/apidoc/templates/bootstrap/layouts/main.php'); ?>
$types = $renderer->getNavTypes(isset($type) ? $type : null, $types); $types = $renderer->getNavTypes(isset($type) ? $type : null, $types);
ksort($types); ksort($types);
$nav = []; $nav = [];
foreach($types as $i=>$class) { foreach ($types as $i => $class) {
$namespace = $class->namespace; $namespace = $class->namespace;
if (empty($namespace)) { if (empty($namespace)) {
$namespace = 'Not namespaced classes'; $namespace = 'Not namespaced classes';
......
...@@ -19,7 +19,7 @@ $this->beginContent('@yii/apidoc/templates/bootstrap/layouts/main.php'); ?> ...@@ -19,7 +19,7 @@ $this->beginContent('@yii/apidoc/templates/bootstrap/layouts/main.php'); ?>
'url' => $this->context->generateGuideUrl('index.md'), 'url' => $this->context->generateGuideUrl('index.md'),
'active' => isset($currentFile) && (basename($currentFile) == 'index.md'), 'active' => isset($currentFile) && (basename($currentFile) == 'index.md'),
]; ];
foreach($headlines as $file => $headline) { foreach ($headlines as $file => $headline) {
$nav[] = [ $nav[] = [
'label' => $headline, 'label' => $headline,
'url' => $this->context->generateGuideUrl($file), 'url' => $this->context->generateGuideUrl($file),
......
...@@ -54,7 +54,7 @@ $this->beginPage(); ...@@ -54,7 +54,7 @@ $this->beginPage();
if (!empty($this->context->extensions)) if (!empty($this->context->extensions))
{ {
$extItems = []; $extItems = [];
foreach($this->context->extensions as $ext) { foreach ($this->context->extensions as $ext) {
$extItems[] = [ $extItems[] = [
'label' => $ext, 'label' => $ext,
'url' => "./ext-{$ext}-index.html", 'url' => "./ext-{$ext}-index.html",
......
...@@ -3,6 +3,7 @@ ...@@ -3,6 +3,7 @@
use yii\apidoc\models\ClassDoc; use yii\apidoc\models\ClassDoc;
use yii\apidoc\models\InterfaceDoc; use yii\apidoc\models\InterfaceDoc;
use yii\apidoc\models\TraitDoc; use yii\apidoc\models\TraitDoc;
/** /**
* @var ClassDoc[]|InterfaceDoc[]|TraitDoc[] $types * @var ClassDoc[]|InterfaceDoc[]|TraitDoc[] $types
* @var yii\web\View $this * @var yii\web\View $this
...@@ -29,7 +30,7 @@ if (isset($readme)) { ...@@ -29,7 +30,7 @@ if (isset($readme)) {
</tr> </tr>
<?php <?php
ksort($types); ksort($types);
foreach($types as $i=>$class): foreach ($types as $i => $class):
?> ?>
<tr> <tr>
<td><?= $renderer->createTypeLink($class, $class, $class->name) ?></td> <td><?= $renderer->createTypeLink($class, $class, $class->name) ?></td>
......
...@@ -32,7 +32,7 @@ ArrayHelper::multisort($constants, 'name'); ...@@ -32,7 +32,7 @@ ArrayHelper::multisort($constants, 'name');
<tr> <tr>
<th>Constant</th><th>Value</th><th>Description</th><th>Defined By</th> <th>Constant</th><th>Value</th><th>Description</th><th>Defined By</th>
</tr> </tr>
<?php foreach($constants as $constant): ?> <?php foreach ($constants as $constant): ?>
<tr<?= $constant->definedBy != $type->name ? ' class="inherited"' : '' ?> id="<?= $constant->name ?>"> <tr<?= $constant->definedBy != $type->name ? ' class="inherited"' : '' ?> id="<?= $constant->name ?>">
<td><?= $constant->name ?><a name="<?= $constant->name ?>-detail"></a></td> <td><?= $constant->name ?><a name="<?= $constant->name ?>-detail"></a></td>
<td><?= $constant->value ?></td> <td><?= $constant->value ?></td>
......
...@@ -16,12 +16,12 @@ if (empty($events)) { ...@@ -16,12 +16,12 @@ if (empty($events)) {
ArrayHelper::multisort($events, 'name'); ArrayHelper::multisort($events, 'name');
?> ?>
<h2>Event Details</h2> <h2>Event Details</h2>
<?php foreach($events as $event): ?> <?php foreach ($events as $event): ?>
<div class="detailHeader h3" id="<?= $event->name.'-detail' ?>"> <div class="detailHeader h3" id="<?= $event->name.'-detail' ?>">
<?= $event->name ?> <?= $event->name ?>
<span class="detailHeaderTag small"> <span class="detailHeaderTag small">
event event
<?php if(!empty($event->since)): ?> <?php if (!empty($event->since)): ?>
(available since version <?= $event->since ?>) (available since version <?= $event->since ?>)
<?php endif; ?> <?php endif; ?>
</span> </span>
......
...@@ -32,13 +32,13 @@ ArrayHelper::multisort($events, 'name'); ...@@ -32,13 +32,13 @@ ArrayHelper::multisort($events, 'name');
<tr> <tr>
<th>Event</th><th>Type</th><th>Description</th><th>Defined By</th> <th>Event</th><th>Type</th><th>Description</th><th>Defined By</th>
</tr> </tr>
<?php foreach($events as $event): ?> <?php foreach ($events as $event): ?>
<tr<?= $event->definedBy != $type->name ? ' class="inherited"' : '' ?> id="<?= $event->name ?>"> <tr<?= $event->definedBy != $type->name ? ' class="inherited"' : '' ?> id="<?= $event->name ?>">
<td><?= $renderer->createSubjectLink($event) ?></td> <td><?= $renderer->createSubjectLink($event) ?></td>
<td><?= $renderer->createTypeLink($event->types) ?></td> <td><?= $renderer->createTypeLink($event->types) ?></td>
<td> <td>
<?= ApiMarkdown::process($event->shortDescription, $event->definedBy, true) ?> <?= ApiMarkdown::process($event->shortDescription, $event->definedBy, true) ?>
<?php if(!empty($event->since)): ?> <?php if (!empty($event->since)): ?>
(available since version <?= $event->since ?>) (available since version <?= $event->since ?>)
<?php endif; ?> <?php endif; ?>
</td> </td>
......
...@@ -21,7 +21,7 @@ ArrayHelper::multisort($methods, 'name'); ...@@ -21,7 +21,7 @@ ArrayHelper::multisort($methods, 'name');
?> ?>
<h2>Method Details</h2> <h2>Method Details</h2>
<?php foreach($methods as $method): ?> <?php foreach ($methods as $method): ?>
<div class="detailHeader h3" id="<?= $method->name . '()-detail' ?>"> <div class="detailHeader h3" id="<?= $method->name . '()-detail' ?>">
<?= $method->name ?>() <?= $method->name ?>()
...@@ -29,7 +29,7 @@ ArrayHelper::multisort($methods, 'name'); ...@@ -29,7 +29,7 @@ ArrayHelper::multisort($methods, 'name');
<?= $method->visibility ?> <?= $method->visibility ?>
method method
<?php if (!empty($method->since)): ?> <?php if (!empty($method->since)): ?>
(available since version <?php echo $method->since; ?>) (available since version <?= $method->since ?>)
<?php endif; ?> <?php endif; ?>
</span> </span>
</div> </div>
...@@ -38,22 +38,22 @@ ArrayHelper::multisort($methods, 'name'); ...@@ -38,22 +38,22 @@ ArrayHelper::multisort($methods, 'name');
<tr><td colspan="3"> <tr><td colspan="3">
<div class="signature2"><?= $renderer->renderMethodSignature($method) ?></div> <div class="signature2"><?= $renderer->renderMethodSignature($method) ?></div>
</td></tr> </td></tr>
<?php if(!empty($method->params) || !empty($method->return) || !empty($method->exceptions)): ?> <?php if (!empty($method->params) || !empty($method->return) || !empty($method->exceptions)): ?>
<?php foreach($method->params as $param): ?> <?php foreach ($method->params as $param): ?>
<tr> <tr>
<td class="paramNameCol"><?= $param->name ?></td> <td class="paramNameCol"><?= $param->name ?></td>
<td class="paramTypeCol"><?= $renderer->createTypeLink($param->types) ?></td> <td class="paramTypeCol"><?= $renderer->createTypeLink($param->types) ?></td>
<td class="paramDescCol"><?= ApiMarkdown::process($param->description, $type) ?></td> <td class="paramDescCol"><?= ApiMarkdown::process($param->description, $type) ?></td>
</tr> </tr>
<?php endforeach; ?> <?php endforeach; ?>
<?php if(!empty($method->return)): ?> <?php if (!empty($method->return)): ?>
<tr> <tr>
<td class="paramNameCol"><?= 'return'; ?></td> <td class="paramNameCol"><?= 'return'; ?></td>
<td class="paramTypeCol"><?= $renderer->createTypeLink($method->returnTypes); ?></td> <td class="paramTypeCol"><?= $renderer->createTypeLink($method->returnTypes); ?></td>
<td class="paramDescCol"><?= ApiMarkdown::process($method->return, $type); ?></td> <td class="paramDescCol"><?= ApiMarkdown::process($method->return, $type); ?></td>
</tr> </tr>
<?php endif; ?> <?php endif; ?>
<?php foreach($method->exceptions as $exception => $description): ?> <?php foreach ($method->exceptions as $exception => $description): ?>
<tr> <tr>
<td class="paramNameCol"><?= 'throws' ?></td> <td class="paramNameCol"><?= 'throws' ?></td>
<td class="paramTypeCol"><?= $renderer->createTypeLink($exception) ?></td> <td class="paramTypeCol"><?= $renderer->createTypeLink($exception) ?></td>
......
...@@ -36,8 +36,8 @@ if ($protected && count($type->getProtectedMethods()) == 0 || !$protected && cou ...@@ -36,8 +36,8 @@ if ($protected && count($type->getProtectedMethods()) == 0 || !$protected && cou
<?php <?php
$methods = $type->methods; $methods = $type->methods;
ArrayHelper::multisort($methods, 'name'); ArrayHelper::multisort($methods, 'name');
foreach($methods as $method): ?> foreach ($methods as $method): ?>
<?php if($protected && $method->visibility == 'protected' || !$protected && $method->visibility != 'protected'): ?> <?php if ($protected && $method->visibility == 'protected' || !$protected && $method->visibility != 'protected'): ?>
<tr<?= $method->definedBy != $type->name ? ' class="inherited"' : '' ?> id="<?= $method->name ?>()"> <tr<?= $method->definedBy != $type->name ? ' class="inherited"' : '' ?> id="<?= $method->name ?>()">
<td><?= $renderer->createSubjectLink($method, $method->name.'()') ?></td> <td><?= $renderer->createSubjectLink($method, $method->name.'()') ?></td>
<td><?= ApiMarkdown::process($method->shortDescription, $method->definedBy, true) ?></td> <td><?= ApiMarkdown::process($method->shortDescription, $method->definedBy, true) ?></td>
......
...@@ -21,17 +21,17 @@ ArrayHelper::multisort($properties, 'name'); ...@@ -21,17 +21,17 @@ ArrayHelper::multisort($properties, 'name');
?> ?>
<h2>Property Details</h2> <h2>Property Details</h2>
<?php foreach($properties as $property): ?> <?php foreach ($properties as $property): ?>
<div class="detailHeader h3" id="<?= $property->name.'-detail' ?>"> <div class="detailHeader h3" id="<?= $property->name.'-detail' ?>">
<?= $property->name ?> <?= $property->name ?>
<span class="detailHeaderTag small"> <span class="detailHeaderTag small">
<?= $property->visibility ?> <?= $property->visibility ?>
<?php if($property->getIsReadOnly()) echo ' <em>read-only</em> '; ?> <?php if ($property->getIsReadOnly()) echo ' <em>read-only</em> '; ?>
<?php if($property->getIsWriteOnly()) echo ' <em>write-only</em> '; ?> <?php if ($property->getIsWriteOnly()) echo ' <em>write-only</em> '; ?>
property property
<?php if(!empty($property->since)): ?> <?php if (!empty($property->since)): ?>
(available since version <?php echo $property->since; ?>) (available since version <?= $property->since ?>)
<?php endif; ?> <?php endif; ?>
</span> </span>
</div> </div>
......
...@@ -36,8 +36,8 @@ if ($protected && count($type->getProtectedProperties()) == 0 || !$protected && ...@@ -36,8 +36,8 @@ if ($protected && count($type->getProtectedProperties()) == 0 || !$protected &&
<?php <?php
$properties = $type->properties; $properties = $type->properties;
ArrayHelper::multisort($properties, 'name'); ArrayHelper::multisort($properties, 'name');
foreach($properties as $property): ?> foreach ($properties as $property): ?>
<?php if($protected && $property->visibility == 'protected' || !$protected && $property->visibility != 'protected'): ?> <?php if ($protected && $property->visibility == 'protected' || !$protected && $property->visibility != 'protected'): ?>
<tr<?= $property->definedBy != $type->name ? ' class="inherited"' : '' ?> id="<?= $property->name ?>"> <tr<?= $property->definedBy != $type->name ? ' class="inherited"' : '' ?> id="<?= $property->name ?>">
<td><?= $renderer->createSubjectLink($property) ?></td> <td><?= $renderer->createSubjectLink($property) ?></td>
<td><?= $renderer->createTypeLink($property->types) ?></td> <td><?= $renderer->createTypeLink($property->types) ?></td>
......
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
*/ */
$see = []; $see = [];
foreach($object->tags as $tag) { foreach ($object->tags as $tag) {
/** @var $tag phpDocumentor\Reflection\DocBlock\Tag\SeeTag */ /** @var $tag phpDocumentor\Reflection\DocBlock\Tag\SeeTag */
if (get_class($tag) == 'phpDocumentor\Reflection\DocBlock\Tag\SeeTag') { if (get_class($tag) == 'phpDocumentor\Reflection\DocBlock\Tag\SeeTag') {
$ref = $tag->getReference(); $ref = $tag->getReference();
...@@ -24,7 +24,7 @@ if (empty($see)) { ...@@ -24,7 +24,7 @@ if (empty($see)) {
<div class="SeeAlso"> <div class="SeeAlso">
<h4>See Also</h4> <h4>See Also</h4>
<ul> <ul>
<?php foreach($see as $ref): ?> <?php foreach ($see as $ref): ?>
<li><?= \yii\apidoc\helpers\ApiMarkdown::process($ref, $object->definedBy, true) ?></li> <li><?= \yii\apidoc\helpers\ApiMarkdown::process($ref, $object->definedBy, true) ?></li>
<?php endforeach; ?> <?php endforeach; ?>
</ul> </ul>
......
...@@ -4,6 +4,7 @@ use yii\apidoc\helpers\ApiMarkdown; ...@@ -4,6 +4,7 @@ use yii\apidoc\helpers\ApiMarkdown;
use yii\apidoc\models\ClassDoc; use yii\apidoc\models\ClassDoc;
use yii\apidoc\models\InterfaceDoc; use yii\apidoc\models\InterfaceDoc;
use yii\apidoc\models\TraitDoc; use yii\apidoc\models\TraitDoc;
/** /**
* @var ClassDoc|InterfaceDoc|TraitDoc $type * @var ClassDoc|InterfaceDoc|TraitDoc $type
* @var yii\web\View $this * @var yii\web\View $this
...@@ -30,16 +31,16 @@ $renderer = $this->context; ...@@ -30,16 +31,16 @@ $renderer = $this->context;
?></h1> ?></h1>
<div id="nav"> <div id="nav">
<a href="index.html">All Classes</a> <a href="index.html">All Classes</a>
<?php if(!($type instanceof InterfaceDoc) && !empty($type->properties)): ?> <?php if (!($type instanceof InterfaceDoc) && !empty($type->properties)): ?>
| <a href="#properties">Properties</a> | <a href="#properties">Properties</a>
<?php endif; ?> <?php endif; ?>
<?php if(!empty($type->methods)): ?> <?php if (!empty($type->methods)): ?>
| <a href="#methods">Methods</a> | <a href="#methods">Methods</a>
<?php endif; ?> <?php endif; ?>
<?php if($type instanceof ClassDoc && !empty($type->events)): ?> <?php if ($type instanceof ClassDoc && !empty($type->events)): ?>
| <a href="#events">Events</a> | <a href="#events">Events</a>
<?php endif; ?> <?php endif; ?>
<?php if($type instanceof ClassDoc && !empty($type->constants)): ?> <?php if ($type instanceof ClassDoc && !empty($type->constants)): ?>
| <a href="#constants">Constants</a> | <a href="#constants">Constants</a>
<?php endif; ?> <?php endif; ?>
</div> </div>
...@@ -55,10 +56,10 @@ $renderer = $this->context; ...@@ -55,10 +56,10 @@ $renderer = $this->context;
<?php if ($type instanceof ClassDoc && !empty($type->interfaces)): ?> <?php if ($type instanceof ClassDoc && !empty($type->interfaces)): ?>
<tr><th>Implements</th><td><?= $renderer->renderInterfaces($type->interfaces) ?></td></tr> <tr><th>Implements</th><td><?= $renderer->renderInterfaces($type->interfaces) ?></td></tr>
<?php endif; ?> <?php endif; ?>
<?php if(!($type instanceof InterfaceDoc) && !empty($type->traits)): ?> <?php if (!($type instanceof InterfaceDoc) && !empty($type->traits)): ?>
<tr><th>Uses Traits</th><td><?= $renderer->renderTraits($type->traits) ?></td></tr> <tr><th>Uses Traits</th><td><?= $renderer->renderTraits($type->traits) ?></td></tr>
<?php endif; ?> <?php endif; ?>
<?php if($type instanceof ClassDoc && !empty($type->subclasses)): ?> <?php if ($type instanceof ClassDoc && !empty($type->subclasses)): ?>
<tr><th>Subclasses</th><td><?= $renderer->renderClasses($type->subclasses) ?></td></tr> <tr><th>Subclasses</th><td><?= $renderer->renderClasses($type->subclasses) ?></td></tr>
<?php endif; ?> <?php endif; ?>
<?php if ($type instanceof InterfaceDoc && !empty($type->implementedBy)): ?> <?php if ($type instanceof InterfaceDoc && !empty($type->implementedBy)): ?>
...@@ -67,7 +68,7 @@ $renderer = $this->context; ...@@ -67,7 +68,7 @@ $renderer = $this->context;
<?php if ($type instanceof TraitDoc && !empty($type->usedBy)): ?> <?php if ($type instanceof TraitDoc && !empty($type->usedBy)): ?>
<tr><th>Implemented by</th><td><?= $renderer->renderClasses($type->usedBy) ?></td></tr> <tr><th>Implemented by</th><td><?= $renderer->renderClasses($type->usedBy) ?></td></tr>
<?php endif; ?> <?php endif; ?>
<?php if(!empty($type->since)): ?> <?php if (!empty($type->since)): ?>
<tr><th>Available since version</th><td><?= $type->since ?></td></tr> <tr><th>Available since version</th><td><?= $type->since ?></td></tr>
<?php endif; ?> <?php endif; ?>
<?php if(($sourceUrl = $renderer->getSourceUrl($type)) !== null): ?> <?php if(($sourceUrl = $renderer->getSourceUrl($type)) !== null): ?>
...@@ -84,8 +85,8 @@ $renderer = $this->context; ...@@ -84,8 +85,8 @@ $renderer = $this->context;
</div> </div>
<a name="properties"></a> <a name="properties"></a>
<?= $this->render('@yii/apidoc/templates/html/views/propertySummary', ['type' => $type,'protected' => false]) ?> <?= $this->render('@yii/apidoc/templates/html/views/propertySummary', ['type' => $type, 'protected' => false]) ?>
<?= $this->render('@yii/apidoc/templates/html/views/propertySummary', ['type' => $type,'protected' => true]) ?> <?= $this->render('@yii/apidoc/templates/html/views/propertySummary', ['type' => $type, 'protected' => true]) ?>
<a name="methods"></a> <a name="methods"></a>
<?= $this->render('@yii/apidoc/templates/html/views/methodSummary', ['type' => $type, 'protected' => false]) ?> <?= $this->render('@yii/apidoc/templates/html/views/methodSummary', ['type' => $type, 'protected' => false]) ?>
...@@ -99,6 +100,6 @@ $renderer = $this->context; ...@@ -99,6 +100,6 @@ $renderer = $this->context;
<?= $this->render('@yii/apidoc/templates/html/views/propertyDetails', ['type' => $type]) ?> <?= $this->render('@yii/apidoc/templates/html/views/propertyDetails', ['type' => $type]) ?>
<?= $this->render('@yii/apidoc/templates/html/views/methodDetails', ['type' => $type]) ?> <?= $this->render('@yii/apidoc/templates/html/views/methodDetails', ['type' => $type]) ?>
<?php if($type instanceof ClassDoc): ?> <?php if ($type instanceof ClassDoc): ?>
<?= $this->render('@yii/apidoc/templates/html/views/eventDetails', ['type' => $type]) ?> <?= $this->render('@yii/apidoc/templates/html/views/eventDetails', ['type' => $type]) ?>
<?php endif; ?> <?php endif; ?>
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\apidoc\templates\online; namespace yii\apidoc\templates\online;
use yii\apidoc\models\Context; use yii\apidoc\models\Context;
use yii\apidoc\models\TypeDoc; use yii\apidoc\models\TypeDoc;
use yii\console\Controller; use yii\console\Controller;
...@@ -36,7 +37,7 @@ class ApiRenderer extends \yii\apidoc\templates\html\ApiRenderer ...@@ -36,7 +37,7 @@ class ApiRenderer extends \yii\apidoc\templates\html\ApiRenderer
} }
$packages = []; $packages = [];
$notNamespaced = []; $notNamespaced = [];
foreach(array_merge($context->classes, $context->interfaces, $context->traits) as $type) { foreach (array_merge($context->classes, $context->interfaces, $context->traits) as $type) {
/** @var TypeDoc $type */ /** @var TypeDoc $type */
if (empty($type->namespace)) { if (empty($type->namespace)) {
$notNamespaced[] = str_replace('\\', '-', $type->name); $notNamespaced[] = str_replace('\\', '-', $type->name);
...@@ -46,7 +47,7 @@ class ApiRenderer extends \yii\apidoc\templates\html\ApiRenderer ...@@ -46,7 +47,7 @@ class ApiRenderer extends \yii\apidoc\templates\html\ApiRenderer
} }
ksort($packages); ksort($packages);
$packages = array_merge(['Not namespaced' => $notNamespaced], $packages); $packages = array_merge(['Not namespaced' => $notNamespaced], $packages);
foreach($packages as $name => $classes) { foreach ($packages as $name => $classes) {
sort($packages[$name]); sort($packages[$name]);
} }
file_put_contents($targetDir . '/packages.txt', serialize($packages)); file_put_contents($targetDir . '/packages.txt', serialize($packages));
......
...@@ -3,6 +3,7 @@ ...@@ -3,6 +3,7 @@
use yii\apidoc\models\ClassDoc; use yii\apidoc\models\ClassDoc;
use yii\apidoc\models\InterfaceDoc; use yii\apidoc\models\InterfaceDoc;
use yii\apidoc\models\TraitDoc; use yii\apidoc\models\TraitDoc;
/** /**
* @var ClassDoc[]|InterfaceDoc[]|TraitDoc[] $types * @var ClassDoc[]|InterfaceDoc[]|TraitDoc[] $types
* @var yii\web\View $this * @var yii\web\View $this
...@@ -22,7 +23,7 @@ use yii\apidoc\models\TraitDoc; ...@@ -22,7 +23,7 @@ use yii\apidoc\models\TraitDoc;
</tr> </tr>
<?php <?php
ksort($types); ksort($types);
foreach($types as $i=>$class): foreach ($types as $i => $class):
?> ?>
<tr> <tr>
<td><?= $this->context->typeLink($class, $class->name) ?></td> <td><?= $this->context->typeLink($class, $class->name) ?></td>
......
...@@ -175,7 +175,7 @@ class OAuth1 extends BaseOAuth ...@@ -175,7 +175,7 @@ class OAuth1 extends BaseOAuth
} }
case 'POST': { case 'POST': {
$curlOptions[CURLOPT_POST] = true; $curlOptions[CURLOPT_POST] = true;
if (!empty($params)){ if (!empty($params)) {
$curlOptions[CURLOPT_POSTFIELDS] = $params; $curlOptions[CURLOPT_POSTFIELDS] = $params;
} }
$authorizationHeader = $this->composeAuthorizationHeader($params); $authorizationHeader = $this->composeAuthorizationHeader($params);
......
...@@ -58,14 +58,16 @@ class OAuthToken extends Object ...@@ -58,14 +58,16 @@ class OAuthToken extends Object
/** /**
* @param string $expireDurationParamKey expire duration param key. * @param string $expireDurationParamKey expire duration param key.
*/ */
public function setExpireDurationParamKey($expireDurationParamKey) { public function setExpireDurationParamKey($expireDurationParamKey)
{
$this->_expireDurationParamKey = $expireDurationParamKey; $this->_expireDurationParamKey = $expireDurationParamKey;
} }
/** /**
* @return string expire duration param key. * @return string expire duration param key.
*/ */
public function getExpireDurationParamKey() { public function getExpireDurationParamKey()
{
if ($this->_expireDurationParamKey === null) { if ($this->_expireDurationParamKey === null) {
$this->_expireDurationParamKey = $this->defaultExpireDurationParamKey(); $this->_expireDurationParamKey = $this->defaultExpireDurationParamKey();
} }
...@@ -75,14 +77,16 @@ class OAuthToken extends Object ...@@ -75,14 +77,16 @@ class OAuthToken extends Object
/** /**
* @return array * @return array
*/ */
public function getParams() { public function getParams()
{
return $this->_params; return $this->_params;
} }
/** /**
* @param array $params * @param array $params
*/ */
public function setParams(array $params) { public function setParams(array $params)
{
$this->_params = $params; $this->_params = $params;
} }
...@@ -91,7 +95,8 @@ class OAuthToken extends Object ...@@ -91,7 +95,8 @@ class OAuthToken extends Object
* @param string $name param name. * @param string $name param name.
* @param mixed $value param value, * @param mixed $value param value,
*/ */
public function setParam($name, $value) { public function setParam($name, $value)
{
$this->_params[$name] = $value; $this->_params[$name] = $value;
} }
...@@ -100,7 +105,8 @@ class OAuthToken extends Object ...@@ -100,7 +105,8 @@ class OAuthToken extends Object
* @param string $name param name. * @param string $name param name.
* @return mixed param value. * @return mixed param value.
*/ */
public function getParam($name) { public function getParam($name)
{
return isset($this->_params[$name]) ? $this->_params[$name] : null; return isset($this->_params[$name]) ? $this->_params[$name] : null;
} }
...@@ -109,7 +115,8 @@ class OAuthToken extends Object ...@@ -109,7 +115,8 @@ class OAuthToken extends Object
* @param string $token token value. * @param string $token token value.
* @return static self reference. * @return static self reference.
*/ */
public function setToken($token) { public function setToken($token)
{
$this->setParam($this->tokenParamKey, $token); $this->setParam($this->tokenParamKey, $token);
} }
...@@ -117,7 +124,8 @@ class OAuthToken extends Object ...@@ -117,7 +124,8 @@ class OAuthToken extends Object
* Returns token value. * Returns token value.
* @return string token value. * @return string token value.
*/ */
public function getToken() { public function getToken()
{
return $this->getParam($this->tokenParamKey); return $this->getParam($this->tokenParamKey);
} }
...@@ -125,7 +133,8 @@ class OAuthToken extends Object ...@@ -125,7 +133,8 @@ class OAuthToken extends Object
* Sets the token secret value. * Sets the token secret value.
* @param string $tokenSecret token secret. * @param string $tokenSecret token secret.
*/ */
public function setTokenSecret($tokenSecret) { public function setTokenSecret($tokenSecret)
{
$this->setParam($this->tokenSecretParamKey, $tokenSecret); $this->setParam($this->tokenSecretParamKey, $tokenSecret);
} }
...@@ -133,7 +142,8 @@ class OAuthToken extends Object ...@@ -133,7 +142,8 @@ class OAuthToken extends Object
* Returns the token secret value. * Returns the token secret value.
* @return string token secret value. * @return string token secret value.
*/ */
public function getTokenSecret() { public function getTokenSecret()
{
return $this->getParam($this->tokenSecretParamKey); return $this->getParam($this->tokenSecretParamKey);
} }
...@@ -141,7 +151,8 @@ class OAuthToken extends Object ...@@ -141,7 +151,8 @@ class OAuthToken extends Object
* Sets token expire duration. * Sets token expire duration.
* @param string $expireDuration token expiration duration. * @param string $expireDuration token expiration duration.
*/ */
public function setExpireDuration($expireDuration) { public function setExpireDuration($expireDuration)
{
$this->setParam($this->getExpireDurationParamKey(), $expireDuration); $this->setParam($this->getExpireDurationParamKey(), $expireDuration);
} }
...@@ -149,7 +160,8 @@ class OAuthToken extends Object ...@@ -149,7 +160,8 @@ class OAuthToken extends Object
* Returns the token expiration duration. * Returns the token expiration duration.
* @return integer token expiration duration. * @return integer token expiration duration.
*/ */
public function getExpireDuration() { public function getExpireDuration()
{
return $this->getParam($this->getExpireDurationParamKey()); return $this->getParam($this->getExpireDurationParamKey());
} }
...@@ -157,7 +169,8 @@ class OAuthToken extends Object ...@@ -157,7 +169,8 @@ class OAuthToken extends Object
* Fetches default expire duration param key. * Fetches default expire duration param key.
* @return string expire duration param key. * @return string expire duration param key.
*/ */
protected function defaultExpireDurationParamKey() { protected function defaultExpireDurationParamKey()
{
$expireDurationParamKey = 'expires_in'; $expireDurationParamKey = 'expires_in';
foreach ($this->getParams() as $name => $value) { foreach ($this->getParams() as $name => $value) {
if (strpos($name, 'expir') !== false) { if (strpos($name, 'expir') !== false) {
...@@ -172,7 +185,8 @@ class OAuthToken extends Object ...@@ -172,7 +185,8 @@ class OAuthToken extends Object
* Checks if token has expired. * Checks if token has expired.
* @return boolean is token expired. * @return boolean is token expired.
*/ */
public function getIsExpired() { public function getIsExpired()
{
$expirationDuration = $this->getExpireDuration(); $expirationDuration = $this->getExpireDuration();
if (empty($expirationDuration)) { if (empty($expirationDuration)) {
return false; return false;
...@@ -184,7 +198,8 @@ class OAuthToken extends Object ...@@ -184,7 +198,8 @@ class OAuthToken extends Object
* Checks if token is valid. * Checks if token is valid.
* @return boolean is token valid. * @return boolean is token valid.
*/ */
public function getIsValid() { public function getIsValid()
{
$token = $this->getToken(); $token = $this->getToken();
return (!empty($token) && !$this->getIsExpired()); return (!empty($token) && !$this->getIsExpired());
} }
......
...@@ -243,10 +243,10 @@ class OpenId extends BaseClient implements ClientInterface ...@@ -243,10 +243,10 @@ class OpenId extends BaseClient implements ClientInterface
if ($this->verifyPeer !== null) { if ($this->verifyPeer !== null) {
curl_setopt($curl, CURLOPT_SSL_VERIFYPEER, $this->verifyPeer); curl_setopt($curl, CURLOPT_SSL_VERIFYPEER, $this->verifyPeer);
if($this->capath) { if ($this->capath) {
curl_setopt($curl, CURLOPT_CAPATH, $this->capath); curl_setopt($curl, CURLOPT_CAPATH, $this->capath);
} }
if($this->cainfo) { if ($this->cainfo) {
curl_setopt($curl, CURLOPT_CAINFO, $this->cainfo); curl_setopt($curl, CURLOPT_CAINFO, $this->cainfo);
} }
} }
......
...@@ -147,7 +147,8 @@ class LinkedIn extends OAuth2 ...@@ -147,7 +147,8 @@ class LinkedIn extends OAuth2
* Generates the auth state value. * Generates the auth state value.
* @return string auth state value. * @return string auth state value.
*/ */
protected function generateAuthState() { protected function generateAuthState()
{
return sha1(uniqid(get_class($this), true)); return sha1(uniqid(get_class($this), true));
} }
......
...@@ -70,7 +70,7 @@ class NavBar extends Widget ...@@ -70,7 +70,7 @@ class NavBar extends Widget
*/ */
public $screenReaderToggleText = 'Toggle navigation'; public $screenReaderToggleText = 'Toggle navigation';
/** /**
* @var bool whether the navbar content should be included in an inner div container which by default * @var boolean whether the navbar content should be included in an inner div container which by default
* adds left and right padding. Set this to false for a 100% width navbar. * adds left and right padding. Set this to false for a 100% width navbar.
*/ */
public $renderInnerContainer = true; public $renderInnerContainer = true;
......
...@@ -133,7 +133,7 @@ class Progress extends Widget ...@@ -133,7 +133,7 @@ class Progress extends Widget
/** /**
* Generates a bar * Generates a bar
* @param int $percent the percentage of the bar * @param integer $percent the percentage of the bar
* @param string $label, optional, the label to display at the bar * @param string $label, optional, the label to display at the bar
* @param array $options the HTML attributes of the bar * @param array $options the HTML attributes of the bar
* @return string the rendering result. * @return string the rendering result.
......
...@@ -192,7 +192,7 @@ class Installer extends LibraryInstaller ...@@ -192,7 +192,7 @@ class Installer extends LibraryInstaller
if (!file_exists($yiiDir)) { if (!file_exists($yiiDir)) {
mkdir($yiiDir, 0777, true); mkdir($yiiDir, 0777, true);
} }
foreach(['Yii.php', 'BaseYii.php', 'classes.php'] as $file) { foreach (['Yii.php', 'BaseYii.php', 'classes.php'] as $file) {
file_put_contents($yiiDir . '/' . $file, <<<EOF file_put_contents($yiiDir . '/' . $file, <<<EOF
<?php <?php
/** /**
...@@ -213,7 +213,7 @@ EOF ...@@ -213,7 +213,7 @@ EOF
protected function removeBaseYiiFiles() protected function removeBaseYiiFiles()
{ {
$yiiDir = $this->vendorDir . '/yiisoft/yii2'; $yiiDir = $this->vendorDir . '/yiisoft/yii2';
foreach(['Yii.php', 'BaseYii.php', 'classes.php'] as $file) { foreach (['Yii.php', 'BaseYii.php', 'classes.php'] as $file) {
if (file_exists($yiiDir . '/' . $file)) { if (file_exists($yiiDir . '/' . $file)) {
unlink($yiiDir . '/' . $file); unlink($yiiDir . '/' . $file);
} }
......
...@@ -168,5 +168,4 @@ class LogTarget extends Target ...@@ -168,5 +168,4 @@ class LogTarget extends Target
# / 2 because messages are in couple (begin/end) # / 2 because messages are in couple (begin/end)
return count($profileLogs) / 2; return count($profileLogs) / 2;
} }
} }
...@@ -37,5 +37,4 @@ abstract class Base extends Component implements MatcherInterface ...@@ -37,5 +37,4 @@ abstract class Base extends Component implements MatcherInterface
{ {
return !empty($this->baseValue) || ($this->baseValue === '0'); return !empty($this->baseValue) || ($this->baseValue === '0');
} }
} }
...@@ -175,5 +175,4 @@ class DbPanel extends Panel ...@@ -175,5 +175,4 @@ class DbPanel extends Panel
{ {
return (($this->criticalQueryThreshold !== null) && ($count > $this->criticalQueryThreshold)); return (($this->criticalQueryThreshold !== null) && ($count > $this->criticalQueryThreshold));
} }
} }
...@@ -102,5 +102,4 @@ class MailPanel extends Panel ...@@ -102,5 +102,4 @@ class MailPanel extends Panel
} }
return $attr; return $attr;
} }
} }
...@@ -35,4 +35,3 @@ echo $this->render('panels/config/table', [ ...@@ -35,4 +35,3 @@ echo $this->render('panels/config/table', [
]); ]);
echo $panel->getPhpInfo(); echo $panel->getPhpInfo();
?>
\ No newline at end of file
...@@ -23,7 +23,7 @@ use yii\helpers\Html; ...@@ -23,7 +23,7 @@ use yii\helpers\Html;
</tr> </tr>
</thead> </thead>
<tbody> <tbody>
<?php foreach($values as $name => $value): ?> <?php foreach ($values as $name => $value): ?>
<tr> <tr>
<th style="width: 200px;"><?= Html::encode($name) ?></th> <th style="width: 200px;"><?= Html::encode($name) ?></th>
<td style="overflow:auto"><?= Html::encode($value) ?></td> <td style="overflow:auto"><?= Html::encode($value) ?></td>
......
...@@ -67,4 +67,3 @@ echo GridView::widget([ ...@@ -67,4 +67,3 @@ echo GridView::widget([
] ]
], ],
]); ]);
?>
...@@ -70,4 +70,3 @@ echo GridView::widget([ ...@@ -70,4 +70,3 @@ echo GridView::widget([
], ],
], ],
]); ]);
?>
<?php <?php
use yii\grid\GridView; use yii\grid\GridView;
use yii\helpers\Html; use yii\helpers\Html;
?> ?>
<h1>Performance Profiling</h1> <h1>Performance Profiling</h1>
<p>Total processing time: <b><?= $time ?></b>; Peak memory: <b><?= $memory ?></b>.</p> <p>Total processing time: <b><?= $time ?></b>; Peak memory: <b><?= $memory ?></b>.</p>
...@@ -50,4 +51,3 @@ echo GridView::widget([ ...@@ -50,4 +51,3 @@ echo GridView::widget([
], ],
], ],
]); ]);
?>
...@@ -23,7 +23,7 @@ use yii\helpers\VarDumper; ...@@ -23,7 +23,7 @@ use yii\helpers\VarDumper;
</tr> </tr>
</thead> </thead>
<tbody> <tbody>
<?php foreach($values as $name => $value): ?> <?php foreach ($values as $name => $value): ?>
<tr> <tr>
<th style="width: 200px;"><?= Html::encode($name) ?></th> <th style="width: 200px;"><?= Html::encode($name) ?></th>
<td><?= htmlspecialchars(VarDumper::dumpAsString($value), ENT_QUOTES|ENT_SUBSTITUTE, \Yii::$app->charset, true) ?></td> <td><?= htmlspecialchars(VarDumper::dumpAsString($value), ENT_QUOTES|ENT_SUBSTITUTE, \Yii::$app->charset, true) ?></td>
......
...@@ -156,7 +156,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface ...@@ -156,7 +156,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface
} }
$models = $this->createModels($result['hits']['hits']); $models = $this->createModels($result['hits']['hits']);
if ($this->asArray && !$this->indexBy) { if ($this->asArray && !$this->indexBy) {
foreach($models as $key => $model) { foreach ($models as $key => $model) {
if ($pk === '_id') { if ($pk === '_id') {
$model['_source']['_id'] = $model['_id']; $model['_source']['_id'] = $model['_id'];
} }
...@@ -168,7 +168,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface ...@@ -168,7 +168,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface
$this->findWith($this->with, $models); $this->findWith($this->with, $models);
} }
if (!$this->asArray) { if (!$this->asArray) {
foreach($models as $model) { foreach ($models as $model) {
$model->afterFind(); $model->afterFind();
} }
} }
...@@ -226,7 +226,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface ...@@ -226,7 +226,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface
/** @var ActiveRecord $modelClass */ /** @var ActiveRecord $modelClass */
$modelClass = $this->modelClass; $modelClass = $this->modelClass;
$pk = $modelClass::primaryKey()[0]; $pk = $modelClass::primaryKey()[0];
foreach($models as $key => $model) { foreach ($models as $key => $model) {
if ($pk === '_id') { if ($pk === '_id') {
$model['_source']['_id'] = $model['_id']; $model['_source']['_id'] = $model['_id'];
} }
...@@ -238,7 +238,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface ...@@ -238,7 +238,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface
$this->findWith($this->with, $models); $this->findWith($this->with, $models);
} }
if (!$this->asArray) { if (!$this->asArray) {
foreach($models as $model) { foreach ($models as $model) {
$model->afterFind(); $model->afterFind();
} }
} }
......
...@@ -122,7 +122,7 @@ class ActiveRecord extends BaseActiveRecord ...@@ -122,7 +122,7 @@ class ActiveRecord extends BaseActiveRecord
$command = static::getDb()->createCommand(); $command = static::getDb()->createCommand();
$result = $command->mget(static::index(), static::type(), $primaryKeys, $options); $result = $command->mget(static::index(), static::type(), $primaryKeys, $options);
$models = []; $models = [];
foreach($result['docs'] as $doc) { foreach ($result['docs'] as $doc) {
if ($doc['exists']) { if ($doc['exists']) {
$model = static::instantiate($doc); $model = static::instantiate($doc);
static::populateRecord($model, $doc); static::populateRecord($model, $doc);
...@@ -422,7 +422,7 @@ class ActiveRecord extends BaseActiveRecord ...@@ -422,7 +422,7 @@ class ActiveRecord extends BaseActiveRecord
return 0; return 0;
} }
$bulk = ''; $bulk = '';
foreach($primaryKeys as $pk) { foreach ($primaryKeys as $pk) {
$action = Json::encode([ $action = Json::encode([
"update" => [ "update" => [
"_id" => $pk, "_id" => $pk,
...@@ -441,7 +441,7 @@ class ActiveRecord extends BaseActiveRecord ...@@ -441,7 +441,7 @@ class ActiveRecord extends BaseActiveRecord
$response = static::getDb()->post($url, [], $bulk); $response = static::getDb()->post($url, [], $bulk);
$n=0; $n=0;
$errors = []; $errors = [];
foreach($response['items'] as $item) { foreach ($response['items'] as $item) {
if (isset($item['update']['error'])) { if (isset($item['update']['error'])) {
$errors[] = $item['update']; $errors[] = $item['update'];
} elseif ($item['update']['ok']) { } elseif ($item['update']['ok']) {
...@@ -480,7 +480,7 @@ class ActiveRecord extends BaseActiveRecord ...@@ -480,7 +480,7 @@ class ActiveRecord extends BaseActiveRecord
return 0; return 0;
} }
$bulk = ''; $bulk = '';
foreach($primaryKeys as $pk) { foreach ($primaryKeys as $pk) {
$action = Json::encode([ $action = Json::encode([
"update" => [ "update" => [
"_id" => $pk, "_id" => $pk,
...@@ -489,7 +489,7 @@ class ActiveRecord extends BaseActiveRecord ...@@ -489,7 +489,7 @@ class ActiveRecord extends BaseActiveRecord
], ],
]); ]);
$script = ''; $script = '';
foreach($counters as $counter => $value) { foreach ($counters as $counter => $value) {
$script .= "ctx._source.$counter += $counter;\n"; $script .= "ctx._source.$counter += $counter;\n";
} }
$data = Json::encode([ $data = Json::encode([
...@@ -504,7 +504,7 @@ class ActiveRecord extends BaseActiveRecord ...@@ -504,7 +504,7 @@ class ActiveRecord extends BaseActiveRecord
$response = static::getDb()->post($url, [], $bulk); $response = static::getDb()->post($url, [], $bulk);
$n=0; $n=0;
$errors = []; $errors = [];
foreach($response['items'] as $item) { foreach ($response['items'] as $item) {
if (isset($item['update']['error'])) { if (isset($item['update']['error'])) {
$errors[] = $item['update']; $errors[] = $item['update'];
} elseif ($item['update']['ok']) { } elseif ($item['update']['ok']) {
...@@ -543,7 +543,7 @@ class ActiveRecord extends BaseActiveRecord ...@@ -543,7 +543,7 @@ class ActiveRecord extends BaseActiveRecord
return 0; return 0;
} }
$bulk = ''; $bulk = '';
foreach($primaryKeys as $pk) { foreach ($primaryKeys as $pk) {
$bulk .= Json::encode([ $bulk .= Json::encode([
"delete" => [ "delete" => [
"_id" => $pk, "_id" => $pk,
...@@ -558,7 +558,7 @@ class ActiveRecord extends BaseActiveRecord ...@@ -558,7 +558,7 @@ class ActiveRecord extends BaseActiveRecord
$response = static::getDb()->post($url, [], $bulk); $response = static::getDb()->post($url, [], $bulk);
$n=0; $n=0;
$errors = []; $errors = [];
foreach($response['items'] as $item) { foreach ($response['items'] as $item) {
if (isset($item['delete']['error'])) { if (isset($item['delete']['error'])) {
$errors[] = $item['delete']; $errors[] = $item['delete'];
} elseif ($item['delete']['found'] && $item['delete']['ok']) { } elseif ($item['delete']['found'] && $item['delete']['ok']) {
......
...@@ -364,7 +364,7 @@ class Command extends Component ...@@ -364,7 +364,7 @@ class Command extends Component
* @param $pattern * @param $pattern
* @param $settings * @param $settings
* @param $mappings * @param $mappings
* @param int $order * @param integer $order
* @return mixed * @return mixed
* @see http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/indices-templates.html * @see http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/indices-templates.html
*/ */
......
...@@ -29,7 +29,7 @@ class Connection extends Component ...@@ -29,7 +29,7 @@ class Connection extends Component
const EVENT_AFTER_OPEN = 'afterOpen'; const EVENT_AFTER_OPEN = 'afterOpen';
/** /**
* @var bool whether to autodetect available cluster nodes on [[open()]] * @var boolean whether to autodetect available cluster nodes on [[open()]]
*/ */
public $autodetectCluster = true; public $autodetectCluster = true;
/** /**
...@@ -63,7 +63,7 @@ class Connection extends Component ...@@ -63,7 +63,7 @@ class Connection extends Component
public function init() public function init()
{ {
foreach($this->nodes as $node) { foreach ($this->nodes as $node) {
if (!isset($node['http_address'])) { if (!isset($node['http_address'])) {
throw new InvalidConfigException('Elasticsearch node needs at least a http_address configured.'); throw new InvalidConfigException('Elasticsearch node needs at least a http_address configured.');
} }
...@@ -210,7 +210,7 @@ class Connection extends Component ...@@ -210,7 +210,7 @@ class Connection extends Component
private function createUrl($path, $options = []) private function createUrl($path, $options = [])
{ {
if (!is_string($path)) { if (!is_string($path)) {
$url = implode('/', array_map(function($a) { $url = implode('/', array_map(function ($a) {
return urlencode(is_array($a) ? implode(',', $a) : $a); return urlencode(is_array($a) ? implode(',', $a) : $a);
}, $path)); }, $path));
if (!empty($options)) { if (!empty($options)) {
...@@ -240,7 +240,7 @@ class Connection extends Component ...@@ -240,7 +240,7 @@ class Connection extends Component
// http://www.php.net/manual/en/function.curl-setopt.php#82418 // http://www.php.net/manual/en/function.curl-setopt.php#82418
CURLOPT_HTTPHEADER => ['Expect:'], CURLOPT_HTTPHEADER => ['Expect:'],
CURLOPT_WRITEFUNCTION => function($curl, $data) use (&$body) { CURLOPT_WRITEFUNCTION => function ($curl, $data) use (&$body) {
$body .= $data; $body .= $data;
return mb_strlen($data, '8bit'); return mb_strlen($data, '8bit');
}, },
......
...@@ -177,7 +177,7 @@ class QueryBuilder extends \yii\base\Object ...@@ -177,7 +177,7 @@ class QueryBuilder extends \yii\base\Object
private function buildHashCondition($condition) private function buildHashCondition($condition)
{ {
$parts = []; $parts = [];
foreach($condition as $attribute => $value) { foreach ($condition as $attribute => $value) {
if ($attribute == '_id') { if ($attribute == '_id') {
if ($value == null) { // there is no null pk if ($value == null) { // there is no null pk
$parts[] = ['script' => ['script' => '0==1']]; $parts[] = ['script' => ['script' => '0==1']];
......
...@@ -13,7 +13,6 @@ use yii\base\InvalidConfigException; ...@@ -13,7 +13,6 @@ use yii\base\InvalidConfigException;
use yii\base\Model; use yii\base\Model;
use yii\web\View; use yii\web\View;
/** /**
* This is the base class for all generator classes. * This is the base class for all generator classes.
* *
......
...@@ -73,7 +73,7 @@ HTML; ...@@ -73,7 +73,7 @@ HTML;
} }
} }
// Added lines only on the right side // Added lines only on the right side
else if ($change['tag'] === 'insert') { elseif ($change['tag'] === 'insert') {
foreach ($change['changed']['lines'] as $no => $line) { foreach ($change['changed']['lines'] as $no => $line) {
$toLine = $change['changed']['offset'] + $no + 1; $toLine = $change['changed']['offset'] + $no + 1;
$html .= <<<HTML $html .= <<<HTML
...@@ -86,7 +86,7 @@ HTML; ...@@ -86,7 +86,7 @@ HTML;
} }
} }
// Show deleted lines only on the left side // Show deleted lines only on the left side
else if ($change['tag'] === 'delete') { elseif ($change['tag'] === 'delete') {
foreach ($change['base']['lines'] as $no => $line) { foreach ($change['base']['lines'] as $no => $line) {
$fromLine = $change['base']['offset'] + $no + 1; $fromLine = $change['base']['offset'] + $no + 1;
$html .= <<<HTML $html .= <<<HTML
...@@ -99,7 +99,7 @@ HTML; ...@@ -99,7 +99,7 @@ HTML;
} }
} }
// Show modified lines on both sides // Show modified lines on both sides
else if ($change['tag'] === 'replace') { elseif ($change['tag'] === 'replace') {
foreach ($change['base']['lines'] as $no => $line) { foreach ($change['base']['lines'] as $no => $line) {
$fromLine = $change['base']['offset'] + $no + 1; $fromLine = $change['base']['offset'] + $no + 1;
$html .= <<<HTML $html .= <<<HTML
......
...@@ -18,7 +18,7 @@ namespace <?= $generator->ns ?>; ...@@ -18,7 +18,7 @@ namespace <?= $generator->ns ?>;
class <?= $generator->getControllerClass() ?> extends <?= '\\' . trim($generator->baseClass, '\\') . "\n" ?> class <?= $generator->getControllerClass() ?> extends <?= '\\' . trim($generator->baseClass, '\\') . "\n" ?>
{ {
<?php foreach($generator->getActionIDs() as $action): ?> <?php foreach ($generator->getActionIDs() as $action): ?>
public function action<?= Inflector::id2camel($action) ?>() public function action<?= Inflector::id2camel($action) ?>()
{ {
return $this->render('<?= $action ?>'); return $this->render('<?= $action ?>');
......
...@@ -499,5 +499,4 @@ class Generator extends \yii\gii\Generator ...@@ -499,5 +499,4 @@ class Generator extends \yii\gii\Generator
return $model->attributes(); return $model->attributes();
} }
} }
} }
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\jui; namespace yii\jui;
use yii\web\AssetBundle; use yii\web\AssetBundle;
/** /**
......
...@@ -111,7 +111,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface ...@@ -111,7 +111,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface
$this->findWith($this->with, $models); $this->findWith($this->with, $models);
} }
if (!$this->asArray) { if (!$this->asArray) {
foreach($models as $model) { foreach ($models as $model) {
$model->afterFind(); $model->afterFind();
} }
} }
......
...@@ -626,7 +626,8 @@ class Collection extends Object ...@@ -626,7 +626,8 @@ class Collection extends Object
* @return array the highest scoring documents, in descending order by score. * @return array the highest scoring documents, in descending order by score.
* @throws Exception on failure. * @throws Exception on failure.
*/ */
public function fullTextSearch($search, $condition = [], $fields = [], $options = []) { public function fullTextSearch($search, $condition = [], $fields = [], $options = [])
{
$command = [ $command = [
'search' => $search 'search' => $search
]; ];
......
...@@ -56,7 +56,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface ...@@ -56,7 +56,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface
$this->findWith($this->with, $models); $this->findWith($this->with, $models);
} }
if (!$this->asArray) { if (!$this->asArray) {
foreach($models as $model) { foreach ($models as $model) {
$model->afterFind(); $model->afterFind();
} }
} }
......
...@@ -87,10 +87,10 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface ...@@ -87,10 +87,10 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface
// TODO add support for orderBy // TODO add support for orderBy
$data = $this->executeScript($db, 'All'); $data = $this->executeScript($db, 'All');
$rows = []; $rows = [];
foreach($data as $dataRow) { foreach ($data as $dataRow) {
$row = []; $row = [];
$c = count($dataRow); $c = count($dataRow);
for($i = 0; $i < $c; ) { for ($i = 0; $i < $c;) {
$row[$dataRow[$i++]] = $dataRow[$i++]; $row[$dataRow[$i++]] = $dataRow[$i++];
} }
$rows[] = $row; $rows[] = $row;
...@@ -101,7 +101,7 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface ...@@ -101,7 +101,7 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface
$this->findWith($this->with, $models); $this->findWith($this->with, $models);
} }
if (!$this->asArray) { if (!$this->asArray) {
foreach($models as $model) { foreach ($models as $model) {
$model->afterFind(); $model->afterFind();
} }
} }
...@@ -128,7 +128,7 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface ...@@ -128,7 +128,7 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface
} }
$row = []; $row = [];
$c = count($data); $c = count($data);
for($i = 0; $i < $c; ) { for ($i = 0; $i < $c;) {
$row[$data[$i++]] = $data[$i++]; $row[$data[$i++]] = $data[$i++];
} }
if ($this->asArray) { if ($this->asArray) {
...@@ -336,7 +336,7 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface ...@@ -336,7 +336,7 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface
if (count($this->where) == 1) { if (count($this->where) == 1) {
$pks = (array) reset($this->where); $pks = (array) reset($this->where);
} else { } else {
foreach($this->where as $values) { foreach ($this->where as $values) {
if (is_array($values)) { if (is_array($values)) {
// TODO support composite IN for composite PK // TODO support composite IN for composite PK
throw new NotSupportedException('Find by composite PK is not supported by redis ActiveRecord.'); throw new NotSupportedException('Find by composite PK is not supported by redis ActiveRecord.');
...@@ -357,7 +357,7 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface ...@@ -357,7 +357,7 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface
} }
$i = 0; $i = 0;
$data = []; $data = [];
foreach($pks as $pk) { foreach ($pks as $pk) {
if (++$i > $start && ($limit === null || $i <= $start + $limit)) { if (++$i > $start && ($limit === null || $i <= $start + $limit)) {
$key = $modelClass::keyPrefix() . ':a:' . $modelClass::buildKey($pk); $key = $modelClass::keyPrefix() . ':a:' . $modelClass::buildKey($pk);
$result = $db->executeCommand('HGETALL', [$key]); $result = $db->executeCommand('HGETALL', [$key]);
...@@ -380,10 +380,10 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface ...@@ -380,10 +380,10 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface
return count($data); return count($data);
case 'Column': case 'Column':
$column = []; $column = [];
foreach($data as $dataRow) { foreach ($data as $dataRow) {
$row = []; $row = [];
$c = count($dataRow); $c = count($dataRow);
for($i = 0; $i < $c; ) { for ($i = 0; $i < $c;) {
$row[$dataRow[$i++]] = $dataRow[$i++]; $row[$dataRow[$i++]] = $dataRow[$i++];
} }
$column[] = $row[$columnName]; $column[] = $row[$columnName];
...@@ -391,9 +391,9 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface ...@@ -391,9 +391,9 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface
return $column; return $column;
case 'Sum': case 'Sum':
$sum = 0; $sum = 0;
foreach($data as $dataRow) { foreach ($data as $dataRow) {
$c = count($dataRow); $c = count($dataRow);
for($i = 0; $i < $c; ) { for ($i = 0; $i < $c;) {
if ($dataRow[$i++] == $columnName) { if ($dataRow[$i++] == $columnName) {
$sum += $dataRow[$i]; $sum += $dataRow[$i];
break; break;
...@@ -404,10 +404,10 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface ...@@ -404,10 +404,10 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface
case 'Average': case 'Average':
$sum = 0; $sum = 0;
$count = 0; $count = 0;
foreach($data as $dataRow) { foreach ($data as $dataRow) {
$count++; $count++;
$c = count($dataRow); $c = count($dataRow);
for($i = 0; $i < $c; ) { for ($i = 0; $i < $c;) {
if ($dataRow[$i++] == $columnName) { if ($dataRow[$i++] == $columnName) {
$sum += $dataRow[$i]; $sum += $dataRow[$i];
break; break;
...@@ -417,9 +417,9 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface ...@@ -417,9 +417,9 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface
return $sum / $count; return $sum / $count;
case 'Min': case 'Min':
$min = null; $min = null;
foreach($data as $dataRow) { foreach ($data as $dataRow) {
$c = count($dataRow); $c = count($dataRow);
for($i = 0; $i < $c; ) { for ($i = 0; $i < $c;) {
if ($dataRow[$i++] == $columnName && ($min == null || $dataRow[$i] < $min)) { if ($dataRow[$i++] == $columnName && ($min == null || $dataRow[$i] < $min)) {
$min = $dataRow[$i]; $min = $dataRow[$i];
break; break;
...@@ -429,9 +429,9 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface ...@@ -429,9 +429,9 @@ class ActiveQuery extends \yii\base\Component implements ActiveQueryInterface
return $min; return $min;
case 'Max': case 'Max':
$max = null; $max = null;
foreach($data as $dataRow) { foreach ($data as $dataRow) {
$c = count($dataRow); $c = count($dataRow);
for($i = 0; $i < $c; ) { for ($i = 0; $i < $c;) {
if ($dataRow[$i++] == $columnName && ($max == null || $dataRow[$i] > $max)) { if ($dataRow[$i++] == $columnName && ($max == null || $dataRow[$i] > $max)) {
$max = $dataRow[$i]; $max = $dataRow[$i];
break; break;
......
...@@ -139,7 +139,7 @@ class ActiveRecord extends BaseActiveRecord ...@@ -139,7 +139,7 @@ class ActiveRecord extends BaseActiveRecord
$key = static::keyPrefix() . ':a:' . static::buildKey($pk); $key = static::keyPrefix() . ':a:' . static::buildKey($pk);
// save attributes // save attributes
$args = [$key]; $args = [$key];
foreach($values as $attribute => $value) { foreach ($values as $attribute => $value) {
$args[] = $attribute; $args[] = $attribute;
$args[] = $value; $args[] = $value;
} }
...@@ -172,13 +172,13 @@ class ActiveRecord extends BaseActiveRecord ...@@ -172,13 +172,13 @@ class ActiveRecord extends BaseActiveRecord
} }
$db = static::getDb(); $db = static::getDb();
$n=0; $n=0;
foreach(static::fetchPks($condition) as $pk) { foreach (static::fetchPks($condition) as $pk) {
$newPk = $pk; $newPk = $pk;
$pk = static::buildKey($pk); $pk = static::buildKey($pk);
$key = static::keyPrefix() . ':a:' . $pk; $key = static::keyPrefix() . ':a:' . $pk;
// save attributes // save attributes
$args = [$key]; $args = [$key];
foreach($attributes as $attribute => $value) { foreach ($attributes as $attribute => $value) {
if (isset($newPk[$attribute])) { if (isset($newPk[$attribute])) {
$newPk[$attribute] = $value; $newPk[$attribute] = $value;
} }
...@@ -224,9 +224,9 @@ class ActiveRecord extends BaseActiveRecord ...@@ -224,9 +224,9 @@ class ActiveRecord extends BaseActiveRecord
} }
$db = static::getDb(); $db = static::getDb();
$n=0; $n=0;
foreach(static::fetchPks($condition) as $pk) { foreach (static::fetchPks($condition) as $pk) {
$key = static::keyPrefix() . ':a:' . static::buildKey($pk); $key = static::keyPrefix() . ':a:' . static::buildKey($pk);
foreach($counters as $attribute => $value) { foreach ($counters as $attribute => $value) {
$db->executeCommand('HINCRBY', [$key, $attribute, $value]); $db->executeCommand('HINCRBY', [$key, $attribute, $value]);
} }
$n++; $n++;
...@@ -254,7 +254,7 @@ class ActiveRecord extends BaseActiveRecord ...@@ -254,7 +254,7 @@ class ActiveRecord extends BaseActiveRecord
$attributeKeys = []; $attributeKeys = [];
$pks = static::fetchPks($condition); $pks = static::fetchPks($condition);
$db->executeCommand('MULTI'); $db->executeCommand('MULTI');
foreach($pks as $pk) { foreach ($pks as $pk) {
$pk = static::buildKey($pk); $pk = static::buildKey($pk);
$db->executeCommand('LREM', [static::keyPrefix(), 0, $pk]); $db->executeCommand('LREM', [static::keyPrefix(), 0, $pk]);
$attributeKeys[] = static::keyPrefix() . ':a:' . $pk; $attributeKeys[] = static::keyPrefix() . ':a:' . $pk;
...@@ -276,9 +276,9 @@ class ActiveRecord extends BaseActiveRecord ...@@ -276,9 +276,9 @@ class ActiveRecord extends BaseActiveRecord
$primaryKey = static::primaryKey(); $primaryKey = static::primaryKey();
$pks = []; $pks = [];
foreach($records as $record) { foreach ($records as $record) {
$pk = []; $pk = [];
foreach($primaryKey as $key) { foreach ($primaryKey as $key) {
$pk[$key] = $record[$key]; $pk[$key] = $record[$key];
} }
$pks[] = $pk; $pks[] = $pk;
...@@ -304,7 +304,7 @@ class ActiveRecord extends BaseActiveRecord ...@@ -304,7 +304,7 @@ class ActiveRecord extends BaseActiveRecord
} }
ksort($key); // ensure order is always the same ksort($key); // ensure order is always the same
$isNumeric = true; $isNumeric = true;
foreach($key as $value) { foreach ($key as $value) {
if (!is_numeric($value)) { if (!is_numeric($value)) {
$isNumeric = false; $isNumeric = false;
} }
......
...@@ -78,7 +78,7 @@ class Cache extends \yii\caching\Cache ...@@ -78,7 +78,7 @@ class Cache extends \yii\caching\Cache
parent::init(); parent::init();
if (is_string($this->redis)) { if (is_string($this->redis)) {
$this->redis = Yii::$app->getComponent($this->redis); $this->redis = Yii::$app->getComponent($this->redis);
} else if (is_array($this->redis)) { } elseif (is_array($this->redis)) {
if (!isset($this->redis['class'])) { if (!isset($this->redis['class'])) {
$this->redis['class'] = Connection::className(); $this->redis['class'] = Connection::className();
} }
...@@ -145,7 +145,7 @@ class Cache extends \yii\caching\Cache ...@@ -145,7 +145,7 @@ class Cache extends \yii\caching\Cache
protected function setValues($data, $expire) protected function setValues($data, $expire)
{ {
$args = []; $args = [];
foreach($data as $key => $value) { foreach ($data as $key => $value) {
$args[] = $key; $args[] = $key;
$args[] = $value; $args[] = $value;
} }
...@@ -164,7 +164,7 @@ class Cache extends \yii\caching\Cache ...@@ -164,7 +164,7 @@ class Cache extends \yii\caching\Cache
} }
$result = $this->redis->executeCommand('EXEC'); $result = $this->redis->executeCommand('EXEC');
array_shift($result); array_shift($result);
foreach($result as $i => $r) { foreach ($result as $i => $r) {
if ($r != 1) { if ($r != 1) {
$failedKeys[] = $index[$i]; $failedKeys[] = $index[$i];
} }
......
...@@ -45,7 +45,7 @@ class Connection extends Component ...@@ -45,7 +45,7 @@ class Connection extends Component
*/ */
public $hostname = 'localhost'; public $hostname = 'localhost';
/** /**
* @var int the port to use for connecting to the redis server. Default port is 6379. * @var integer the port to use for connecting to the redis server. Default port is 6379.
*/ */
public $port = 6379; public $port = 6379;
/** /**
...@@ -54,7 +54,7 @@ class Connection extends Component ...@@ -54,7 +54,7 @@ class Connection extends Component
*/ */
public $password; public $password;
/** /**
* @var int the redis database to use. This is an integer value starting from 0. Defaults to 0. * @var integer the redis database to use. This is an integer value starting from 0. Defaults to 0.
*/ */
public $database = 0; public $database = 0;
/** /**
...@@ -254,7 +254,7 @@ class Connection extends Component ...@@ -254,7 +254,7 @@ class Connection extends Component
); );
if ($this->_socket) { if ($this->_socket) {
if ($this->dataTimeout !== null) { if ($this->dataTimeout !== null) {
stream_set_timeout($this->_socket, $timeout=(int)$this->dataTimeout, (int) (($this->dataTimeout - $timeout) * 1000000)); stream_set_timeout($this->_socket, $timeout = (int)$this->dataTimeout, (int) (($this->dataTimeout - $timeout) * 1000000));
} }
if ($this->password !== null) { if ($this->password !== null) {
$this->executeCommand('AUTH', [$this->password]); $this->executeCommand('AUTH', [$this->password]);
...@@ -345,13 +345,13 @@ class Connection extends Component ...@@ -345,13 +345,13 @@ class Connection extends Component
* for details on the mentioned reply types. * for details on the mentioned reply types.
* @trows Exception for commands that return [error reply](http://redis.io/topics/protocol#error-reply). * @trows Exception for commands that return [error reply](http://redis.io/topics/protocol#error-reply).
*/ */
public function executeCommand($name, $params=[]) public function executeCommand($name, $params = [])
{ {
$this->open(); $this->open();
array_unshift($params, $name); array_unshift($params, $name);
$command = '*' . count($params) . "\r\n"; $command = '*' . count($params) . "\r\n";
foreach($params as $arg) { foreach ($params as $arg) {
$command .= '$' . mb_strlen($arg, '8bit') . "\r\n" . $arg . "\r\n"; $command .= '$' . mb_strlen($arg, '8bit') . "\r\n" . $arg . "\r\n";
} }
......
...@@ -133,6 +133,7 @@ class LuaScriptBuilder extends \yii\base\Object ...@@ -133,6 +133,7 @@ class LuaScriptBuilder extends \yii\base\Object
* @param ActiveQuery $query the query used to build the script * @param ActiveQuery $query the query used to build the script
* @param string $buildResult the lua script for building the result * @param string $buildResult the lua script for building the result
* @param string $return the lua variable that should be returned * @param string $return the lua variable that should be returned
* @throws yii\base\NotSupportedException when query contains unsupported order by condition
* @return string * @return string
*/ */
private function build($query, $buildResult, $return) private function build($query, $buildResult, $return)
...@@ -155,7 +156,7 @@ class LuaScriptBuilder extends \yii\base\Object ...@@ -155,7 +156,7 @@ class LuaScriptBuilder extends \yii\base\Object
$modelClass = $query->modelClass; $modelClass = $query->modelClass;
$key = $this->quoteValue($modelClass::keyPrefix()); $key = $this->quoteValue($modelClass::keyPrefix());
$loadColumnValues = ''; $loadColumnValues = '';
foreach($columns as $column => $alias) { foreach ($columns as $column => $alias) {
$loadColumnValues .= "local $alias=redis.call('HGET',$key .. ':a:' .. pk, '$column')\n"; $loadColumnValues .= "local $alias=redis.call('HGET',$key .. ':a:' .. pk, '$column')\n";
} }
......
...@@ -160,7 +160,7 @@ class Customer extends \yii\redis\ActiveRecord ...@@ -160,7 +160,7 @@ class Customer extends \yii\redis\ActiveRecord
*/ */
public static function active($query) public static function active($query)
{ {
$query->andWhere(array('status' => 1)); $query->andWhere(['status' => 1]);
} }
} }
``` ```
......
...@@ -81,7 +81,7 @@ class Session extends \yii\web\Session ...@@ -81,7 +81,7 @@ class Session extends \yii\web\Session
{ {
if (is_string($this->redis)) { if (is_string($this->redis)) {
$this->redis = Yii::$app->getComponent($this->redis); $this->redis = Yii::$app->getComponent($this->redis);
} else if (is_array($this->redis)) { } elseif (is_array($this->redis)) {
if (!isset($this->redis['class'])) { if (!isset($this->redis['class'])) {
$this->redis['class'] = Connection::className(); $this->redis['class'] = Connection::className();
} }
......
...@@ -135,7 +135,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface ...@@ -135,7 +135,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface
} }
$models = $this->fillUpSnippets($models); $models = $this->fillUpSnippets($models);
if (!$this->asArray) { if (!$this->asArray) {
foreach($models as $model) { foreach ($models as $model) {
$model->afterFind(); $model->afterFind();
} }
} }
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
*/ */
namespace yii\sphinx; namespace yii\sphinx;
use yii\base\NotSupportedException; use yii\base\NotSupportedException;
/** /**
......
...@@ -338,7 +338,7 @@ class Query extends Component implements QueryInterface ...@@ -338,7 +338,7 @@ class Query extends Component implements QueryInterface
/** /**
* Sets the value indicating whether to SELECT DISTINCT or not. * Sets the value indicating whether to SELECT DISTINCT or not.
* @param bool $value whether to SELECT DISTINCT or not. * @param boolean $value whether to SELECT DISTINCT or not.
* @return static the query object itself * @return static the query object itself
*/ */
public function distinct($value = true) public function distinct($value = true)
......
...@@ -422,7 +422,7 @@ class QueryBuilder extends Object ...@@ -422,7 +422,7 @@ class QueryBuilder extends Object
if (strpos($column, '(') === false) { if (strpos($column, '(') === false) {
$column = $this->db->quoteColumnName($column); $column = $this->db->quoteColumnName($column);
} }
$columns[$i] = "$column AS " . $this->db->quoteColumnName($i);; $columns[$i] = "$column AS " . $this->db->quoteColumnName($i);
} elseif (strpos($column, '(') === false) { } elseif (strpos($column, '(') === false) {
if (preg_match('/^(.*?)(?i:\s+as\s+|\s+)([\w\-_\.]+)$/', $column, $matches)) { if (preg_match('/^(.*?)(?i:\s+as\s+|\s+)([\w\-_\.]+)$/', $column, $matches)) {
$columns[$i] = $this->db->quoteColumnName($matches[1]) . ' AS ' . $this->db->quoteColumnName($matches[2]); $columns[$i] = $this->db->quoteColumnName($matches[1]) . ' AS ' . $this->db->quoteColumnName($matches[2]);
...@@ -907,7 +907,8 @@ class QueryBuilder extends Object ...@@ -907,7 +907,8 @@ class QueryBuilder extends Object
* @param array $params the binding parameters to be populated * @param array $params the binding parameters to be populated
* @return string SQL expression, which represents column value * @return string SQL expression, which represents column value
*/ */
protected function composeColumnValue($indexes, $columnName, $value, &$params) { protected function composeColumnValue($indexes, $columnName, $value, &$params)
{
if ($value === null) { if ($value === null) {
return 'NULL'; return 'NULL';
} elseif ($value instanceof Expression) { } elseif ($value instanceof Expression) {
......
...@@ -68,7 +68,8 @@ class TwigSimpleFileLoader implements \Twig_LoaderInterface ...@@ -68,7 +68,8 @@ class TwigSimpleFileLoader implements \Twig_LoaderInterface
* @param string $name file name * @param string $name file name
* @return string absolute path of file * @return string absolute path of file
*/ */
protected function getFilePath($name){ protected function getFilePath($name)
{
return $this->_dir . '/' . $name; return $this->_dir . '/' . $name;
} }
} }
...@@ -118,7 +118,7 @@ class ViewRenderer extends BaseViewRenderer ...@@ -118,7 +118,7 @@ class ViewRenderer extends BaseViewRenderer
} }
// Adding global 'void' function (usage: {{void(App.clientScript.registerScriptFile(...))}}) // Adding global 'void' function (usage: {{void(App.clientScript.registerScriptFile(...))}})
$this->twig->addFunction('void', new \Twig_Function_Function(function($argument){ $this->twig->addFunction('void', new \Twig_Function_Function(function ($argument) {
})); }));
$this->twig->addFunction('path', new \Twig_Function_Function(function ($path, $args = []) { $this->twig->addFunction('path', new \Twig_Function_Function(function ($path, $args = []) {
......
...@@ -19,7 +19,8 @@ class ViewRendererStaticClassProxy ...@@ -19,7 +19,8 @@ class ViewRendererStaticClassProxy
{ {
private $_staticClassName; private $_staticClassName;
public function __construct($staticClassName) { public function __construct($staticClassName)
{
$this->_staticClassName = $staticClassName; $this->_staticClassName = $staticClassName;
} }
......
...@@ -158,7 +158,7 @@ yii = (function ($) { ...@@ -158,7 +158,7 @@ yii = (function ($) {
return {}; return {};
} }
var qs = url.substring(pos + 1).split('&'); var qs = url.substring(pos + 1).split('&');
for(var i = 0, result = {}; i < qs.length; i++){ for (var i = 0, result = {}; i < qs.length; i++) {
qs[i] = qs[i].split('='); qs[i] = qs[i].split('=');
result[decodeURIComponent(qs[i][0])] = decodeURIComponent(qs[i][1]); result[decodeURIComponent(qs[i][0])] = decodeURIComponent(qs[i][1]);
} }
......
...@@ -64,7 +64,7 @@ class ErrorException extends \ErrorException implements Arrayable ...@@ -64,7 +64,7 @@ class ErrorException extends \ErrorException implements Arrayable
* Returns if error is one of fatal type. * Returns if error is one of fatal type.
* *
* @param array $error error got from error_get_last() * @param array $error error got from error_get_last()
* @return bool if error is one of fatal type * @return boolean if error is one of fatal type
*/ */
public static function isFatalError($error) public static function isFatalError($error)
{ {
......
...@@ -406,7 +406,7 @@ abstract class BaseActiveRecord extends Model implements ActiveRecordInterface ...@@ -406,7 +406,7 @@ abstract class BaseActiveRecord extends Model implements ActiveRecordInterface
/** /**
* Check whether the named relation has been populated with records. * Check whether the named relation has been populated with records.
* @param string $name the relation name (case-sensitive) * @param string $name the relation name (case-sensitive)
* @return bool whether relation has been populated with records. * @return boolean whether relation has been populated with records.
*/ */
public function isRelationPopulated($name) public function isRelationPopulated($name)
{ {
......
...@@ -396,7 +396,7 @@ class Query extends Component implements QueryInterface ...@@ -396,7 +396,7 @@ class Query extends Component implements QueryInterface
/** /**
* Sets the value indicating whether to SELECT DISTINCT or not. * Sets the value indicating whether to SELECT DISTINCT or not.
* @param bool $value whether to SELECT DISTINCT or not. * @param boolean $value whether to SELECT DISTINCT or not.
* @return static the query object itself * @return static the query object itself
*/ */
public function distinct($value = true) public function distinct($value = true)
...@@ -754,7 +754,7 @@ class Query extends Component implements QueryInterface ...@@ -754,7 +754,7 @@ class Query extends Component implements QueryInterface
/** /**
* Appends a SQL statement using UNION operator. * Appends a SQL statement using UNION operator.
* @param string|Query $sql the SQL statement to be appended using UNION * @param string|Query $sql the SQL statement to be appended using UNION
* @param bool $all TRUE if using UNION ALL and FALSE if using UNION * @param boolean $all TRUE if using UNION ALL and FALSE if using UNION
* @return static the query object itself * @return static the query object itself
*/ */
public function union($sql, $all = false) public function union($sql, $all = false)
......
...@@ -123,7 +123,7 @@ class BaseConsole ...@@ -123,7 +123,7 @@ class BaseConsole
/** /**
* Scrolls whole page up by sending ANSI control code SU to the terminal. * Scrolls whole page up by sending ANSI control code SU to the terminal.
* New lines are added at the bottom. This is not supported by ANSI.SYS used in windows. * New lines are added at the bottom. This is not supported by ANSI.SYS used in windows.
* @param int $lines number of lines to scroll up * @param integer $lines number of lines to scroll up
*/ */
public static function scrollUp($lines = 1) public static function scrollUp($lines = 1)
{ {
...@@ -133,7 +133,7 @@ class BaseConsole ...@@ -133,7 +133,7 @@ class BaseConsole
/** /**
* Scrolls whole page down by sending ANSI control code SD to the terminal. * Scrolls whole page down by sending ANSI control code SD to the terminal.
* New lines are added at the top. This is not supported by ANSI.SYS used in windows. * New lines are added at the top. This is not supported by ANSI.SYS used in windows.
* @param int $lines number of lines to scroll down * @param integer $lines number of lines to scroll down
*/ */
public static function scrollDown($lines = 1) public static function scrollDown($lines = 1)
{ {
...@@ -474,7 +474,7 @@ class BaseConsole ...@@ -474,7 +474,7 @@ class BaseConsole
* colorcodes will just be removed (And %% will be transformed into %) * colorcodes will just be removed (And %% will be transformed into %)
* *
* @param string $string String to convert * @param string $string String to convert
* @param bool $colored Should the string be colored? * @param boolean $colored Should the string be colored?
* @return string * @return string
*/ */
// TODO rework/refactor according to https://github.com/yiisoft/yii2/issues/746 // TODO rework/refactor according to https://github.com/yiisoft/yii2/issues/746
...@@ -554,7 +554,7 @@ class BaseConsole ...@@ -554,7 +554,7 @@ class BaseConsole
* - not tty consoles * - not tty consoles
* *
* @param mixed $stream * @param mixed $stream
* @return bool true if the stream supports ANSI colors, otherwise false. * @return boolean true if the stream supports ANSI colors, otherwise false.
*/ */
public static function streamSupportsAnsiColors($stream) public static function streamSupportsAnsiColors($stream)
{ {
...@@ -575,7 +575,7 @@ class BaseConsole ...@@ -575,7 +575,7 @@ class BaseConsole
/** /**
* Usage: list($width, $height) = ConsoleHelper::getScreenSize(); * Usage: list($width, $height) = ConsoleHelper::getScreenSize();
* *
* @param bool $refresh whether to force checking and not re-use cached size value. * @param boolean $refresh whether to force checking and not re-use cached size value.
* This is useful to detect changing window size while the application is running but may * This is useful to detect changing window size while the application is running but may
* not get up to date values on every terminal. * not get up to date values on every terminal.
* @return array|boolean An array of ($width, $height) or false when it was not able to determine size. * @return array|boolean An array of ($width, $height) or false when it was not able to determine size.
...@@ -617,7 +617,7 @@ class BaseConsole ...@@ -617,7 +617,7 @@ class BaseConsole
/** /**
* Gets input from STDIN and returns a string right-trimmed for EOLs. * Gets input from STDIN and returns a string right-trimmed for EOLs.
* *
* @param bool $raw If set to true, returns the raw string without trimming * @param boolean $raw If set to true, returns the raw string without trimming
* @return string the string read from stdin * @return string the string read from stdin
*/ */
public static function stdin($raw = false) public static function stdin($raw = false)
...@@ -898,7 +898,7 @@ class BaseConsole ...@@ -898,7 +898,7 @@ class BaseConsole
* @param string|boolean $remove This can be `false` to leave the progress bar on screen and just print a newline. * @param string|boolean $remove This can be `false` to leave the progress bar on screen and just print a newline.
* If set to `true`, the line of the progress bar will be cleared. This may also be a string to be displayed instead * If set to `true`, the line of the progress bar will be cleared. This may also be a string to be displayed instead
* of the progress bar. * of the progress bar.
* @param bool $keepPrefix whether to keep the prefix that has been specified for the progressbar when progressbar * @param boolean $keepPrefix whether to keep the prefix that has been specified for the progressbar when progressbar
* gets removed. Defaults to true. * gets removed. Defaults to true.
* @see startProgress * @see startProgress
* @see updateProgress * @see updateProgress
......
...@@ -147,7 +147,6 @@ class BaseFileHelper ...@@ -147,7 +147,6 @@ class BaseFileHelper
* @param string $src the source directory * @param string $src the source directory
* @param string $dst the destination directory * @param string $dst the destination directory
* @param array $options options for directory copy. Valid options are: * @param array $options options for directory copy. Valid options are:
* @throws \yii\base\InvalidParamException if unable to open directory
* *
* - dirMode: integer, the permission to be set for newly copied directories. Defaults to 0775. * - dirMode: integer, the permission to be set for newly copied directories. Defaults to 0775.
* - fileMode: integer, the permission to be set for newly copied files. Defaults to the current environment setting. * - fileMode: integer, the permission to be set for newly copied files. Defaults to the current environment setting.
...@@ -178,6 +177,7 @@ class BaseFileHelper ...@@ -178,6 +177,7 @@ class BaseFileHelper
* - afterCopy: callback, a PHP callback that is called after each sub-directory or file is successfully copied. * - afterCopy: callback, a PHP callback that is called after each sub-directory or file is successfully copied.
* The signature of the callback should be: `function ($from, $to)`, where `$from` is the sub-directory or * The signature of the callback should be: `function ($from, $to)`, where `$from` is the sub-directory or
* file copied from, while `$to` is the copy target. * file copied from, while `$to` is the copy target.
* @throws \yii\base\InvalidParamException if unable to open directory
*/ */
public static function copyDirectory($src, $dst, $options = []) public static function copyDirectory($src, $dst, $options = [])
{ {
......
...@@ -332,7 +332,7 @@ class BaseInflector ...@@ -332,7 +332,7 @@ class BaseInflector
* Converts an underscored or CamelCase word into a English * Converts an underscored or CamelCase word into a English
* sentence. * sentence.
* @param string $words * @param string $words
* @param bool $ucAll whether to set all words to uppercase * @param boolean $ucAll whether to set all words to uppercase
* @return string * @return string
*/ */
public static function titleize($words, $ucAll = false) public static function titleize($words, $ucAll = false)
...@@ -415,7 +415,7 @@ class BaseInflector ...@@ -415,7 +415,7 @@ class BaseInflector
/** /**
* Returns a human-readable string from $word * Returns a human-readable string from $word
* @param string $word the string to humanize * @param string $word the string to humanize
* @param bool $ucAll whether to set all words to uppercase or not * @param boolean $ucAll whether to set all words to uppercase or not
* @return string * @return string
*/ */
public static function humanize($word, $ucAll = false) public static function humanize($word, $ucAll = false)
...@@ -455,7 +455,7 @@ class BaseInflector ...@@ -455,7 +455,7 @@ class BaseInflector
* [[$transliteration]] array. * [[$transliteration]] array.
* @param string $string An arbitrary string to convert * @param string $string An arbitrary string to convert
* @param string $replacement The replacement to use for spaces * @param string $replacement The replacement to use for spaces
* @param bool $lowercase whether to return the string in lowercase or not. Defaults to `true`. * @param boolean $lowercase whether to return the string in lowercase or not. Defaults to `true`.
* @return string The converted string. * @return string The converted string.
*/ */
public static function slug($string, $replacement = '-', $lowercase = true) public static function slug($string, $replacement = '-', $lowercase = true)
...@@ -484,7 +484,7 @@ class BaseInflector ...@@ -484,7 +484,7 @@ class BaseInflector
/** /**
* Converts number to its ordinal English form. For example, converts 13 to 13th, 2 to 2nd ... * Converts number to its ordinal English form. For example, converts 13 to 13th, 2 to 2nd ...
* @param int $number the number to get its ordinal value * @param integer $number the number to get its ordinal value
* @return string * @return string
*/ */
public static function ordinalize($number) public static function ordinalize($number)
......
...@@ -259,7 +259,7 @@ class MessageFormatter extends Component ...@@ -259,7 +259,7 @@ class MessageFormatter extends Component
/** /**
* Tokenizes a pattern by separating normal text from replaceable patterns * Tokenizes a pattern by separating normal text from replaceable patterns
* @param string $pattern patter to tokenize * @param string $pattern patter to tokenize
* @return array|bool array of tokens or false on failure * @return array|boolean array of tokens or false on failure
*/ */
private static function tokenizePattern($pattern) private static function tokenizePattern($pattern)
{ {
......
...@@ -320,7 +320,7 @@ class YiiRequirementChecker ...@@ -320,7 +320,7 @@ class YiiRequirementChecker
/** /**
* Normalizes requirement ensuring it has correct format. * Normalizes requirement ensuring it has correct format.
* @param array $requirement raw requirement. * @param array $requirement raw requirement.
* @param int $requirementKey requirement key in the list. * @param integer $requirementKey requirement key in the list.
* @return array normalized requirement. * @return array normalized requirement.
*/ */
function normalizeRequirement($requirement, $requirementKey = 0) function normalizeRequirement($requirement, $requirementKey = 0)
......
...@@ -51,7 +51,7 @@ ...@@ -51,7 +51,7 @@
<table class="table table-bordered"> <table class="table table-bordered">
<tr><th>Name</th><th>Result</th><th>Required By</th><th>Memo</th></tr> <tr><th>Name</th><th>Result</th><th>Required By</th><th>Memo</th></tr>
<?php foreach($requirements as $requirement): ?> <?php foreach ($requirements as $requirement): ?>
<tr class="<?php echo $requirement['condition'] ? 'success' : ($requirement['mandatory'] ? 'error' : 'warning') ?>"> <tr class="<?php echo $requirement['condition'] ? 'success' : ($requirement['mandatory'] ? 'error' : 'warning') ?>">
<td> <td>
<?php echo $requirement['name'] ?> <?php echo $requirement['name'] ?>
......
...@@ -64,7 +64,7 @@ class AssetConverter extends Component implements AssetConverterInterface ...@@ -64,7 +64,7 @@ class AssetConverter extends Component implements AssetConverterInterface
* @param string $basePath asset base path and command working directory * @param string $basePath asset base path and command working directory
* @param string $asset the name of the asset file * @param string $asset the name of the asset file
* @param string $result the name of the file to be generated by the converter command * @param string $result the name of the file to be generated by the converter command
* @return bool true on success, false on failure. Failures will be logged. * @return boolean true on success, false on failure. Failures will be logged.
* @throws \yii\base\Exception when the command fails and YII_DEBUG is true. * @throws \yii\base\Exception when the command fails and YII_DEBUG is true.
* In production mode the error will be logged. * In production mode the error will be logged.
*/ */
......
...@@ -90,7 +90,7 @@ class LinkPager extends Widget ...@@ -90,7 +90,7 @@ class LinkPager extends Widget
*/ */
public $lastPageLabel; public $lastPageLabel;
/** /**
* @var bool whether to register link tags in the HTML header for prev, next, first and last page. * @var boolean whether to register link tags in the HTML header for prev, next, first and last page.
* Defaults to `false` to avoid conflicts when multiple pagers are used on one page. * Defaults to `false` to avoid conflicts when multiple pagers are used on one page.
* @see http://www.w3.org/TR/html401/struct/links.html#h-12.1.2 * @see http://www.w3.org/TR/html401/struct/links.html#h-12.1.2
* @see registerLinkTags() * @see registerLinkTags()
......
...@@ -27,7 +27,7 @@ class ElasticSearchTestCase extends TestCase ...@@ -27,7 +27,7 @@ class ElasticSearchTestCase extends TestCase
if (strpos($host, ':')===false) { if (strpos($host, ':')===false) {
$host .= ':9200'; $host .= ':9200';
} }
if(!@stream_socket_client($host, $errorNumber, $errorDescription, 0.5)) { if (!@stream_socket_client($host, $errorNumber, $errorDescription, 0.5)) {
$this->markTestSkipped('No elasticsearch server running at ' . $params['dsn'] . ' : ' . $errorNumber . ' - ' . $errorDescription); $this->markTestSkipped('No elasticsearch server running at ' . $params['dsn'] . ' : ' . $errorNumber . ' - ' . $errorDescription);
} }
...@@ -35,7 +35,7 @@ class ElasticSearchTestCase extends TestCase ...@@ -35,7 +35,7 @@ class ElasticSearchTestCase extends TestCase
} }
/** /**
* @param bool $reset whether to clean up the test database * @param boolean $reset whether to clean up the test database
* @return Connection * @return Connection
*/ */
public function getConnection($reset = true) public function getConnection($reset = true)
......
...@@ -28,7 +28,7 @@ class RedisCacheTest extends CacheTestCase ...@@ -28,7 +28,7 @@ class RedisCacheTest extends CacheTestCase
$this->markTestSkipped('No redis server connection configured.'); $this->markTestSkipped('No redis server connection configured.');
} }
$connection = new Connection($params); $connection = new Connection($params);
if(!@stream_socket_client($connection->hostname . ':' . $connection->port, $errorNumber, $errorDescription, 0.5)) { if (!@stream_socket_client($connection->hostname . ':' . $connection->port, $errorNumber, $errorDescription, 0.5)) {
$this->markTestSkipped('No redis server running at ' . $connection->hostname . ':' . $connection->port . ' : ' . $errorNumber . ' - ' . $errorDescription); $this->markTestSkipped('No redis server running at ' . $connection->hostname . ':' . $connection->port . ' : ' . $errorNumber . ' - ' . $errorDescription);
} }
......
...@@ -21,7 +21,7 @@ abstract class RedisTestCase extends TestCase ...@@ -21,7 +21,7 @@ abstract class RedisTestCase extends TestCase
$this->markTestSkipped('No redis server connection configured.'); $this->markTestSkipped('No redis server connection configured.');
} }
$connection = new Connection($params); $connection = new Connection($params);
if(!@stream_socket_client($connection->hostname . ':' . $connection->port, $errorNumber, $errorDescription, 0.5)) { if (!@stream_socket_client($connection->hostname . ':' . $connection->port, $errorNumber, $errorDescription, 0.5)) {
$this->markTestSkipped('No redis server running at ' . $connection->hostname . ':' . $connection->port . ' : ' . $errorNumber . ' - ' . $errorDescription); $this->markTestSkipped('No redis server running at ' . $connection->hostname . ':' . $connection->port . ' : ' . $errorNumber . ' - ' . $errorDescription);
} }
...@@ -31,7 +31,7 @@ abstract class RedisTestCase extends TestCase ...@@ -31,7 +31,7 @@ abstract class RedisTestCase extends TestCase
} }
/** /**
* @param bool $reset whether to clean up the test database * @param boolean $reset whether to clean up the test database
* @return Connection * @return Connection
*/ */
public function getConnection($reset = true) public function getConnection($reset = true)
......
...@@ -25,7 +25,7 @@ class SchemaTest extends SphinxTestCase ...@@ -25,7 +25,7 @@ class SchemaTest extends SphinxTestCase
$indexes = $schema->getIndexSchemas(); $indexes = $schema->getIndexSchemas();
$this->assertEquals(count($schema->getIndexNames()), count($indexes)); $this->assertEquals(count($schema->getIndexNames()), count($indexes));
foreach($indexes as $index) { foreach ($indexes as $index) {
$this->assertInstanceOf('yii\sphinx\IndexSchema', $index); $this->assertInstanceOf('yii\sphinx\IndexSchema', $index);
} }
} }
...@@ -62,7 +62,7 @@ class SchemaTest extends SphinxTestCase ...@@ -62,7 +62,7 @@ class SchemaTest extends SphinxTestCase
$schema = $this->getConnection()->schema; $schema = $this->getConnection()->schema;
foreach($values as $value) { foreach ($values as $value) {
$this->assertEquals($value[1], $schema->getPdoType($value[0])); $this->assertEquals($value[1], $schema->getPdoType($value[0]));
} }
fclose($fp); fclose($fp);
......
...@@ -82,8 +82,8 @@ class SphinxTestCase extends TestCase ...@@ -82,8 +82,8 @@ class SphinxTestCase extends TestCase
} }
/** /**
* @param bool $reset whether to clean up the test database * @param boolean $reset whether to clean up the test database
* @param bool $open whether to open test database * @param boolean $open whether to open test database
* @return \yii\sphinx\Connection * @return \yii\sphinx\Connection
*/ */
public function getConnection($reset = false, $open = true) public function getConnection($reset = false, $open = true)
...@@ -119,8 +119,8 @@ class SphinxTestCase extends TestCase ...@@ -119,8 +119,8 @@ class SphinxTestCase extends TestCase
} }
/** /**
* @param bool $reset whether to clean up the test database * @param boolean $reset whether to clean up the test database
* @param bool $open whether to open and populate test database * @param boolean $open whether to open and populate test database
* @return \yii\db\Connection * @return \yii\db\Connection
*/ */
public function getDbConnection($reset = true, $open = true) public function getDbConnection($reset = true, $open = true)
......
...@@ -22,7 +22,7 @@ use yii\caching\Cache; ...@@ -22,7 +22,7 @@ use yii\caching\Cache;
abstract class CacheTestCase extends TestCase abstract class CacheTestCase extends TestCase
{ {
/** /**
* @var int virtual time to be returned by mocked time() function. * @var integer virtual time to be returned by mocked time() function.
* Null means normal time() behavior. * Null means normal time() behavior.
*/ */
public static $time; public static $time;
......
...@@ -34,7 +34,7 @@ class DbCacheTest extends CacheTestCase ...@@ -34,7 +34,7 @@ class DbCacheTest extends CacheTestCase
} }
/** /**
* @param bool $reset whether to clean up the test database * @param boolean $reset whether to clean up the test database
* @return \yii\db\Connection * @return \yii\db\Connection
*/ */
public function getConnection($reset = true) public function getConnection($reset = true)
......
...@@ -35,8 +35,8 @@ abstract class DatabaseTestCase extends TestCase ...@@ -35,8 +35,8 @@ abstract class DatabaseTestCase extends TestCase
} }
/** /**
* @param bool $reset whether to clean up the test database * @param boolean $reset whether to clean up the test database
* @param bool $open whether to open and populate test database * @param boolean $open whether to open and populate test database
* @return \yii\db\Connection * @return \yii\db\Connection
*/ */
public function getConnection($reset = true, $open = true) public function getConnection($reset = true, $open = true)
......
...@@ -32,7 +32,7 @@ class SchemaTest extends DatabaseTestCase ...@@ -32,7 +32,7 @@ class SchemaTest extends DatabaseTestCase
$tables = $schema->getTableSchemas(); $tables = $schema->getTableSchemas();
$this->assertEquals(count($schema->getTableNames()), count($tables)); $this->assertEquals(count($schema->getTableNames()), count($tables));
foreach($tables as $table) { foreach ($tables as $table) {
$this->assertInstanceOf('yii\db\TableSchema', $table); $this->assertInstanceOf('yii\db\TableSchema', $table);
} }
} }
...@@ -85,7 +85,7 @@ class SchemaTest extends DatabaseTestCase ...@@ -85,7 +85,7 @@ class SchemaTest extends DatabaseTestCase
/** @var Schema $schema */ /** @var Schema $schema */
$schema = $this->getConnection()->schema; $schema = $this->getConnection()->schema;
foreach($values as $value) { foreach ($values as $value) {
$this->assertEquals($value[1], $schema->getPdoType($value[0])); $this->assertEquals($value[1], $schema->getPdoType($value[0]));
} }
fclose($fp); fclose($fp);
......
...@@ -28,7 +28,7 @@ class CubridSchemaTest extends SchemaTest ...@@ -28,7 +28,7 @@ class CubridSchemaTest extends SchemaTest
/** @var Schema $schema */ /** @var Schema $schema */
$schema = $this->getConnection()->schema; $schema = $this->getConnection()->schema;
foreach($values as $value) { foreach ($values as $value) {
$this->assertEquals($value[1], $schema->getPdoType($value[0])); $this->assertEquals($value[1], $schema->getPdoType($value[0]));
} }
fclose($fp); fclose($fp);
......
...@@ -254,14 +254,14 @@ class FileHelperTest extends TestCase ...@@ -254,14 +254,14 @@ class FileHelperTest extends TestCase
public function testFindFilesExclude() public function testFindFilesExclude()
{ {
$basePath = $this->testFilePath . DIRECTORY_SEPARATOR; $basePath = $this->testFilePath . DIRECTORY_SEPARATOR;
$dirs = ['', 'one', 'one'.DIRECTORY_SEPARATOR.'two', 'three']; $dirs = ['', 'one', 'one' . DIRECTORY_SEPARATOR . 'two', 'three'];
$files = array_fill_keys(array_map(function($n){return "a.$n";}, range(1,8)), 'file contents'); $files = array_fill_keys(array_map(function($n){return "a.$n";}, range(1,8)), 'file contents');
$tree = $files; $tree = $files;
$root = $files; $root = $files;
$flat = []; $flat = [];
foreach($dirs as $dir) { foreach ($dirs as $dir) {
foreach($files as $fileName=>$contents) { foreach ($files as $fileName => $contents) {
$flat[] = rtrim($basePath.$dir,DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.$fileName; $flat[] = rtrim($basePath.$dir,DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.$fileName;
} }
if ($dir === '') continue; if ($dir === '') continue;
......
...@@ -66,7 +66,7 @@ class TargetTest extends TestCase ...@@ -66,7 +66,7 @@ class TargetTest extends TestCase
$this->assertEquals(count($expected), count(static::$messages)); $this->assertEquals(count($expected), count(static::$messages));
$i = 0; $i = 0;
foreach($expected as $e) { foreach ($expected as $e) {
$this->assertEquals('test' . $e, static::$messages[$i++][0]); $this->assertEquals('test' . $e, static::$messages[$i++][0]);
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment